iterate on build

Author: justjake

.vscode/settings.json

@@ -8,6 +8,7 @@
     "lsan_interface.h": "c",
     "math.h": "c",
     "stdbool.h": "c",
-    "emscripten.h": "c"
+    "emscripten.h": "c",
+    "quickjs-atom.h": "c"
   }
 }

c/interface.c

@@ -600,7 +600,7 @@ MaybeAsync(JSValue *) QTS_GetOwnPropertyNames(JSContext *ctx, JSValue **out_ptrs
   }
   *out_ptrs = malloc(sizeof(JSValue) * *out_len);
   for (int i = 0; i < *out_len; i++) {
-    (*out_ptrs)[i] = jsvalue_to_heap(JS_AtomToValue(ctx, tab[i].atom));
+    out_ptrs[i] = jsvalue_to_heap(JS_AtomToValue(ctx, tab[i].atom));
     JS_FreeAtom(ctx, tab[i].atom);
   }
   js_free(ctx, tab);
@@ -840,6 +840,7 @@ OwnedHeapChar *QTS_Typeof(JSContext *ctx, JSValueConst *value) {
   return out;
 }
 
+JSAtom QTS_AtomLength = 0;
 int QTS_GetLength(JSContext *ctx, uint32_t *out_len, JSValueConst *value) {
   JSValue len_val;
   int result;
@@ -848,7 +849,13 @@ int QTS_GetLength(JSContext *ctx, uint32_t *out_len, JSValueConst *value) {
     return -1;
   }
 
-  len_val = JS_GetProperty(ctx, *value, JS_ATOM_length);
+  if (QTS_AtomLength == 0) {
+    // This should result in a constant static atom we don't actually need to
+    // free, since it's interned within quickjs.c
+    QTS_AtomLength = JS_NewAtom(ctx, "length");
+  }
+
+  len_val = JS_GetProperty(ctx, *value, QTS_AtomLength);
   if (JS_IsException(len_val)) {
     return -1;
   }
@@ -865,6 +872,9 @@ typedef enum IsEqualOp {
 } IsEqualOp;
 
 int QTS_IsEqual(JSContext *ctx, JSValueConst *a, JSValueConst *b, IsEqualOp op) {
+#ifdef QTS_USE_QUICKJS_NG
+  return -1;
+#else
   switch (op) {
     case QTS_EqualOp_SameValue:
       return JS_SameValue(ctx, *a, *b);
@@ -874,6 +884,7 @@ int QTS_IsEqual(JSContext *ctx, JSValueConst *a, JSValueConst *b, IsEqualOp op)
     case QTS_EqualOp_StrictEq:
       return JS_StrictEq(ctx, *a, *b);
   }
+#endif
 }
 
 JSValue *QTS_GetGlobalObject(JSContext *ctx) {

packages/internal-tsconfig/tsconfig.json

@@ -35,6 +35,7 @@
     // "importHelpers": true,                 /* Import emit helpers from 'tslib'. */
     // "downlevelIteration": true,            /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
     // "isolatedModules": true,               /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */
+    // "emitDeclarationOnly": true,
 
     /* Strict Type-Checking Options */
     "strict": true /* Enable all strict type-checking options. */,

packages/quickjs-emscripten-core/src/context.ts

@@ -17,7 +17,12 @@ import type { JSPromiseState } from "./deferred-promise"
 import { QuickJSDeferredPromise } from "./deferred-promise"
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 import type { shouldInterruptAfterDeadline } from "./interrupt-helpers"
-import { QuickJSPromisePending, QuickJSUnwrapError } from "./errors"
+import {
+  QuickJSEmscriptenModuleError,
+  QuickJSNotImplemented,
+  QuickJSPromisePending,
+  QuickJSUnwrapError,
+} from "./errors"
 import type { Disposable, DisposableArray, DisposableFail, DisposableSuccess } from "./lifetime"
 import {
   DisposableResult,
@@ -791,7 +796,11 @@ export class QuickJSContext
     }
     this.runtime.assertOwned(a)
     this.runtime.assertOwned(b)
-    return Boolean(this.ffi.QTS_IsEqual(this.ctx.value, a.value, b.value, equalityType))
+    const result = this.ffi.QTS_IsEqual(this.ctx.value, a.value, b.value, equalityType)
+    if (result === -1) {
+      throw new QuickJSNotImplemented("WASM variant does not expose equality")
+    }
+    return Boolean(result)
   }
 
   /**

packages/quickjs-emscripten-core/tsconfig.json

@@ -2,8 +2,6 @@
   "extends": "@jitl/tsconfig/tsconfig.json",
   "include": ["src/**/*"],
   "compilerOptions": {
-    "rootDir": "src",
-    "outDir": "dist",
     "paths": {
       "@jitl/quickjs-ffi-types": ["../quickjs-ffi-types/src"],
       "@jitl/quickjs-ffi-types/*": ["../quickjs-ffi-types/src/*"]

packages/quickjs-emscripten/tsconfig.json

@@ -2,8 +2,6 @@
   "extends": "@jitl/tsconfig/tsconfig.json",
   "include": ["src/*.*ts"],
   "compilerOptions": {
-    "outDir": ".output",
-    "rootDir": "src",
     "paths": {
       "#variants": ["./src/variants.ts", "./src/variants.js"],
       "quickjs-emscripten-core": ["../quickjs-emscripten-core/src"],