Use new PHPStan plugin

Author: justinbeaty

.phpstan.dist.neon

@@ -1,9 +1,11 @@
 includes:
-    - vendor/macopedia/phpstan-magento1/extension.neon
+    - vendor/mahocommerce/maho-phpstan-plugin/extension.neon
     - .phpstan.dist.baseline.neon
     - phar://phpstan.phar/conf/bleedingEdge.neon
 parameters:
     magentoRootPath: %currentWorkingDirectory%
+    bootstrapFiles:
+        - app/Mage.php
     fileExtensions:
       - php
       - phtml

app/Mage.php

@@ -14,8 +14,9 @@
  * @license    https://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-define('DS', DIRECTORY_SEPARATOR);
-define('PS', PATH_SEPARATOR);
+defined('DS') || define('DS', DIRECTORY_SEPARATOR);
+defined('PS') || define('PS', PATH_SEPARATOR);
+
 define('BP', dirname(__DIR__));
 
 Mage::register('original_include_path', get_include_path());

composer.json

@@ -6,6 +6,9 @@
         "AFL-3.0"
     ],
     "type": "magento-source",
+    "repositories": [
+        { "type": "git", "url": "https://github.com/justinbeaty/maho-phpstan-plugin.git" }
+    ],
     "require": {
         "php": ">=7.4 <8.5",
         "ext-ctype": "*",
@@ -50,8 +53,8 @@
         "composer/composer": "^2.7",
         "dealerdirect/phpcodesniffer-composer-installer": "^1.0.0",
         "friendsofphp/php-cs-fixer": "^3.4",
-        "macopedia/phpstan-magento1": "^1.0.5",
         "magento-ecg/coding-standard": "^4.5",
+        "mahocommerce/maho-phpstan-plugin": "dev-topic-v3",
         "openmage/dev-meta-package": "^1.0.5",
         "perftools/php-profiler": "^1.1",
         "phpcompatibility/php-compatibility": "^9.3",