use explicit free for nan buffer to fix issues with electron

justadudewhohacks · justadudewhohacks · commit 047df17b39f5 · 2018-01-19T08:01:22.000+01:00
diff --git a/cc/core/Mat.cc b/cc/core/Mat.cc
@@ -273,8 +273,12 @@ struct Mat::GetDataWorker : SimpleWorker {
 		return "";
 	}
 
+	static void freeBufferCallback(char* data, void* hint) {
+		free(data);
+	}
+
 	FF_VAL getReturnValue() {
-		return Nan::NewBuffer(data, size).ToLocalChecked();
+		return Nan::NewBuffer(data, size, freeBufferCallback, 0).ToLocalChecked();
 	}
 };
 

Original file line number	Diff line number	Diff line change
`@@ -273,8 +273,12 @@ struct Mat::GetDataWorker : SimpleWorker {`
`273`	`273`	`return "";`
`274`	`274`	`}`
`275`	`275`
	`276`	`+ static void freeBufferCallback(char* data, void* hint) {`
	`277`	`+ free(data);`
	`278`	`+ }`
	`279`	`+`
`276`	`280`	`FF_VAL getReturnValue() {`
`277`		`- return Nan::NewBuffer(data, size).ToLocalChecked();`
	`281`	`+ return Nan::NewBuffer(data, size, freeBufferCallback, 0).ToLocalChecked();`
`278`	`282`	`}`
`279`	`283`	`};`
`280`	`284`