Skip to content

getBottomSpace() returns incorrect Y Coordinate in Modal #5

@kingmeers

Description

@kingmeers

Firstly, this is a great component!

Secondly, I understand the reasoning behind adding getBottomSpace() but it doesn't take into consideration whether or not the view is inside a modal, which overlays any tabbed navigation.

I recommend adding a final prop to ensure this is fixed for future issues, let me know if you'd like me to make a PR.

Thank you again!

Samir

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions