BZ-42256: feat: Add support for asynchronous validator in input #133
+43
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinha-sahil
force-pushed
the
release
branch
11 times, most recently
from
99c6c14 to
7acf429
Compare
sinha-sahil
force-pushed
the
release
branch
16 times, most recently
from
766850e to
4225408
Compare
gokulJuspay
approved these changes
Sep 3, 2025
murdore
force-pushed
the
BZ-42256-add-support-for-asynchronous-validator-in-input
branch
from
6f378af to
5c06656
Compare
sinha-sahil
reviewed
Sep 19, 2025
src/lib/Input/Input.svelte
Outdated
| $: state = getValidationState(properties) as ValidationState; | ||
| let state: ValidationState = 'InProgress'; | ||
| $: { |
Collaborator
There was a problem hiding this comment.
avoid adding reactive blocks
itz-PrathamMittal
force-pushed
the
BZ-42256-add-support-for-asynchronous-validator-in-input
branch
from
5c06656 to
a837797
Compare
vigneshJuspay
approved these changes
Sep 24, 2025
pratikgiramkar1
approved these changes
Sep 24, 2025
Nikita172002
approved these changes
Sep 24, 2025
prajwal-jp
reviewed
Sep 25, 2025
| for (const validator of customValidators) { | ||
| const currentResult = await Promise.resolve(validator(inputValue, validationResult)); | ||
| if (currentResult === 'Invalid') { | ||
| validationResult = 'Invalid'; |
Contributor
There was a problem hiding this comment.
once you reach invalid state, you can just return the result. no need to iterate over remaining validators
itz-PrathamMittal
force-pushed
the
BZ-42256-add-support-for-asynchronous-validator-in-input
branch
from
a837797 to
4564494
Compare
prajwal-jp
approved these changes
Sep 25, 2025
src/lib/Input/Input.svelte
Outdated
| // For making this function reactive, prop was passed as param | ||
| function getValidationState(prop: InputProperties): ValidationState { | ||
| const valueValidation: ValidationState = validateInput( | ||
| async function getValidationState(prop: InputProperties): Promise<ValidationState> { |
Contributor
There was a problem hiding this comment.
async function getValidationState(prop: InputProperties): Promise<ValidationState> {
const valueValidation: ValidationState = await validateInput(
prop.value,
prop.dataType,
prop.validationPattern,
prop.inProgressPattern,
prop.validators
);
if (
valueValidation === 'InProgress' &&
prop.value.length > 0 &&
inputElement &&
inputElement !== document.activeElement
) {
state = 'Invalid';
} else {
state = valueValidation;
}
Contributor
There was a problem hiding this comment.
$: getValidationState(properties);
RajuSudhar
approved these changes
Sep 25, 2025
- Add support for asynchronous input validator. - Change return type of custom validator for input component.
itz-PrathamMittal
force-pushed
the
BZ-42256-add-support-for-asynchronous-validator-in-input
branch
from
4564494 to
db203c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev proof:
https://drive.google.com/file/d/1dEH7HftNeAqsOeqesCC6NrqDU4fseYFf/view?usp=sharing