fix: remove duplicate props from button (#502)

Author: fractaljs

apps/ascent/app/docs/content/components/button-group.mdx

@@ -256,7 +256,7 @@ Button group with loading states
     <Button
         text="Processing..."
         buttonType={ButtonType.PRIMARY}
-        isLoading={true}
+        loading={true}
         onClick={() => console.log('Processing')}
     />
 </ButtonGroup>

apps/ascent/app/docs/content/components/button.mdx

@@ -81,23 +81,6 @@ function MyComponent() {
             { content: 'React.ReactNode', hintText: 'React node' },
             { content: '' },
         ],
-        [
-            {
-                content: 'isLoading',
-                hintText:
-                    'Whether the button is in a loading state with spinner',
-            },
-            { content: 'boolean', hintText: 'boolean' },
-            { content: 'false' },
-        ],
-        [
-            {
-                content: 'isDisabled',
-                hintText: 'Whether the button is disabled and non-interactive',
-            },
-            { content: 'boolean', hintText: 'boolean' },
-            { content: 'false' },
-        ],
         [
             {
                 content: 'disabled',

apps/site/src/demos/ModalDemo.tsx

@@ -842,7 +842,7 @@ const ModalDemo = () => {
                         ? {
                               text: config.primaryButtonText,
                               onClick: () => alert('Primary action clicked!'),
-                              isDisabled: config.primaryButtonDisabled,
+                              disabled: config.primaryButtonDisabled,
                               buttonType: config.primaryButtonType,
                           }
                         : undefined
@@ -852,7 +852,7 @@ const ModalDemo = () => {
                         ? {
                               text: config.secondaryButtonText,
                               onClick: () => alert('Secondary action clicked!'),
-                              isDisabled: config.secondaryButtonDisabled,
+                              disabled: config.secondaryButtonDisabled,
                               buttonType: config.secondaryButtonType,
                           }
                         : undefined

apps/site/src/demos/PopoverDemo.tsx

@@ -438,7 +438,7 @@ const PopoverDemo = () => {
                                       text: config.primaryButtonText,
                                       onClick: () =>
                                           alert('Primary action clicked!'),
-                                      isDisabled: config.primaryButtonDisabled,
+                                      disabled: config.primaryButtonDisabled,
                                       buttonType: config.primaryButtonType,
                                   }
                                 : undefined
@@ -449,8 +449,7 @@ const PopoverDemo = () => {
                                       text: config.secondaryButtonText,
                                       onClick: () =>
                                           alert('Secondary action clicked!'),
-                                      isDisabled:
-                                          config.secondaryButtonDisabled,
+                                      disabled: config.secondaryButtonDisabled,
                                       buttonType: config.secondaryButtonType,
                                   }
                                 : undefined

packages/blend/lib/components/Button/types.ts

@@ -33,8 +33,6 @@ export type ButtonProps = {
     text?: string
     leadingIcon?: React.ReactNode
     trailingIcon?: React.ReactNode
-    isLoading?: boolean
-    isDisabled?: boolean
     disabled?: boolean
     onClick?: () => void
     loading?: boolean

packages/blend/lib/components/DataTable/DataTableHeader/index.tsx

@@ -530,7 +530,7 @@ const DataTableHeader = forwardRef<
                                                 alignOffset={-20}
                                                 secondaryAction={{
                                                     onClick: onClearAllFilters,
-                                                    isDisabled:
+                                                    disabled:
                                                         !searchConfig.query.trim() &&
                                                         advancedFilters.length ===
                                                             0,