More testing (#143)

* More testing

* Add test for incompatible environment file

* Move var creation

Author: martinRenou

jupyterlite_xeus_python/build.py

@@ -171,8 +171,6 @@ def _install_pip_dependencies(prefix_path, dependencies, log=None):
             record_csv = csv.reader(record_content.splitlines())
             all_files = [_file[0] for _file in record_csv]
 
-            non_supported_files = [".so", ".a", ".dylib", ".lib", ".exe" ".dll"]
-
             # List of tuples: (path: str, inside_site_packages: bool)
             files = [(_file, not _file.startswith("../../")) for _file in all_files]
 
@@ -183,6 +181,8 @@ def _install_pip_dependencies(prefix_path, dependencies, log=None):
         with open(package_dist_info / "RECORD", "w") as record:
             record.write(fixed_record_data)
 
+        non_supported_files = [".so", ".a", ".dylib", ".lib", ".exe" ".dll"]
+
         # COPY files under `prefix_path`
         for _file, inside_site_packages in files:
             path = Path(_file)

tests/environment-1.yml

@@ -5,4 +5,10 @@ channels:
 dependencies:
   - numpy
   - matplotlib
-  - ipycanvas
+  - pillow
+  - ipywidgets
+  - pip:
+    # Installing a python package that ships a lab extension under share/
+    - ipycanvas
+    # Installing a pure python package
+    - py2vega

tests/environment-2.yml

@@ -0,0 +1,8 @@
+name: xeus-python-kernel-2
+channels:
+  - https://repo.mamba.pm/emscripten-forge
+  - https://repo.mamba.pm/conda-forge
+dependencies:
+  - pip:
+    # Installing NumPy with pip should fail
+    - numpy

tests/test_xeus_python_env.py

@@ -4,6 +4,8 @@
 from tempfile import TemporaryDirectory
 from pathlib import Path
 
+import pytest
+
 from jupyterlite_core.app import LiteStatusApp
 
 from jupyterlite_xeus_python.env_build_addon import XeusPythonEnv
@@ -57,7 +59,45 @@ def test_python_env_from_file_1():
         "/tmp/xeus-python-kernel/envs/xeus-python-kernel-1/bin/xpython_wasm.wasm"
     )
 
+    # Checking pip packages
+    assert os.path.isdir(
+        "/tmp/xeus-python-kernel/envs/xeus-python-kernel-1/lib/python3.10"
+    )
+    assert os.path.isdir(
+        "/tmp/xeus-python-kernel/envs/xeus-python-kernel-1/lib/python3.10/site-packages"
+    )
+    assert os.path.isdir(
+        "/tmp/xeus-python-kernel/envs/xeus-python-kernel-1/lib/python3.10/site-packages/ipywidgets"
+    )
+    assert os.path.isdir(
+        "/tmp/xeus-python-kernel/envs/xeus-python-kernel-1/lib/python3.10/site-packages/ipycanvas"
+    )
+    assert os.path.isdir(
+        "/tmp/xeus-python-kernel/envs/xeus-python-kernel-1/lib/python3.10/site-packages/py2vega"
+    )
+
+    # Checking labextensions
+    assert os.path.isdir(
+        "/tmp/xeus-python-kernel/envs/xeus-python-kernel-1/share/jupyter/labextensions/@jupyter-widgets/jupyterlab-manager"
+    )
+    assert os.path.isdir(
+        "/tmp/xeus-python-kernel/envs/xeus-python-kernel-1/share/jupyter/labextensions/ipycanvas"
+    )
+
     # Check empack output
     assert os.path.isfile(Path(addon.cwd.name) / "empack_env_meta.json")
 
     os.remove(Path(addon.cwd.name) / "empack_env_meta.json")
+
+
+def test_python_env_from_file_2():
+    app = LiteStatusApp(log_level="DEBUG")
+    app.initialize()
+    manager = app.lite_manager
+
+    addon = XeusPythonEnv(manager)
+    addon.environment_file = "environment-2.yml"
+
+    with pytest.raises(RuntimeError, match="Cannot install binary PyPI package"):
+        for step in addon.post_build(manager):
+            pass