Skip to content

Commit 74c3286

Browse files
authored
Merge pull request #36 from martinRenou/remove_settings_registry
Remove settings registry initilization
2 parents 586ed15 + febe907 commit 74c3286

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

src/index.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ import {
33
JupyterFrontEndPlugin
44
} from '@jupyterlab/application';
55

6-
import { ISettingRegistry } from '@jupyterlab/settingregistry';
7-
86
import { ToolbarButton } from '@jupyterlab/apputils';
97

108
import { IFileBrowserFactory } from '@jupyterlab/filebrowser';
@@ -21,13 +19,11 @@ import { FileSystemDrive } from './drive';
2119
const plugin: JupyterFrontEndPlugin<void> = {
2220
id: 'jupyterlab-filesystem-access:plugin',
2321
requires: [IFileBrowserFactory, ITranslator],
24-
optional: [ISettingRegistry],
2522
autoStart: true,
2623
activate: (
2724
app: JupyterFrontEnd,
2825
browser: IFileBrowserFactory,
29-
translator: ITranslator,
30-
settingRegistry: ISettingRegistry | null
26+
translator: ITranslator
3127
) => {
3228
if (!window.showDirectoryPicker) {
3329
// bail if the browser does not support the File System API
@@ -37,10 +33,6 @@ const plugin: JupyterFrontEndPlugin<void> = {
3733
return;
3834
}
3935

40-
if (settingRegistry) {
41-
settingRegistry.load(plugin.id);
42-
}
43-
4436
const { serviceManager } = app;
4537
const { createFileBrowser } = browser;
4638

0 commit comments

Comments
 (0)