Skip to content

Commit 4b06676

Browse files
authored
Merge pull request #1015 from yuvipanda/local-dev
Set development env vars in dev documentation correctly
2 parents 947eb02 + 53eceab commit 4b06676

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

docs/contributing/dev-setup.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ The easiest & safest way to develop & test TLJH is with [Docker](https://www.doc
2424
--detach \
2525
--name=tljh-dev \
2626
--publish 12000:80 \
27+
--env TLJH_BOOTSTRAP_DEV=yes \
28+
--env TLJH_BOOTSTRAP_PIP_SPEC=/srv/src \
29+
--env PATH=/opt/tljh/hub/bin:${PATH} \
2730
--mount type=bind,source="$(pwd)",target=/srv/src \
2831
tljh-systemd
2932
```

integration-tests/Dockerfile

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Systemd inside a Docker container, for CI only
1+
# Systemd inside a Docker container, for CI and local development
22
ARG BASE_IMAGE=ubuntu:22.04
33
FROM $BASE_IMAGE
44

@@ -28,9 +28,4 @@ RUN systemctl set-default multi-user.target
2828

2929
STOPSIGNAL SIGRTMIN+3
3030

31-
# Uncomment these lines for a development install
32-
# ENV TLJH_BOOTSTRAP_DEV=yes
33-
# ENV TLJH_BOOTSTRAP_PIP_SPEC=/srv/src
34-
# ENV PATH=/opt/tljh/hub/bin:${PATH}
35-
3631
CMD ["/bin/bash", "-c", "exec /lib/systemd/systemd --log-target=journal 3>&1"]

0 commit comments

Comments
 (0)