Skip to content

Commit 29c43b7

Browse files
authored
Merge branch 'jupyterhub:main' into main
2 parents 923ae0a + bf76362 commit 29c43b7

File tree

4 files changed

+16
-28
lines changed

4 files changed

+16
-28
lines changed

.github/workflows/test.yml

+3-15
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,6 @@ on:
1212
workflow_dispatch:
1313

1414
jobs:
15-
# https://github.com/pre-commit/action
16-
pre-commit:
17-
name: Lint
18-
runs-on: ubuntu-22.04
19-
steps:
20-
- uses: actions/checkout@v4
21-
- uses: actions/setup-python@v4
22-
with:
23-
python-version: 3.x
24-
- uses: pre-commit/action@v3.0.0
25-
2615
# Run tests
2716
test:
2817
name: Test
@@ -44,7 +33,6 @@ jobs:
4433
- name: Get Docker version
4534
run: |
4635
docker --version
47-
docker-compose --version
4836
4937
- name: Install pytest
5038
run: pip install pytest requests
@@ -54,13 +42,13 @@ jobs:
5442

5543
- name: Run JupyterHub
5644
working-directory: ${{ matrix.example }}
57-
run: docker-compose up --detach
45+
run: docker compose up --detach
5846

5947
- name: Test
6048
working-directory: ${{ matrix.example }}
6149
run: pytest --verbose --capture=no
6250

63-
- name: Print docker-compose logs
51+
- name: Print docker compose logs
6452
if: always()
6553
working-directory: ${{ matrix.example }}
66-
run: docker-compose logs
54+
run: docker compose logs

README.md

+10-10
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Key components of this reference deployment are:
3333
- **Authenticator**: Uses [Native Authenticator](https://github.com/jupyterhub/nativeauthenticator) to authenticate users.
3434
Any user will be allowed to sign up.
3535

36-
- **Spawner**:Uses [DockerSpawner](https://github.com/jupyterhub/dockerspawner)
36+
- **Spawner**: Uses [DockerSpawner](https://github.com/jupyterhub/dockerspawner)
3737
to spawn single-user Jupyter Notebook servers in separate Docker
3838
containers on the same host.
3939

@@ -60,11 +60,11 @@ This deployment uses [JupyterHub Native Authenticator](https://native-authentica
6060

6161
## Build the JupyterHub Docker image
6262

63-
1. Use [docker-compose](https://docs.docker.com/compose/reference/) to build
63+
1. Use [docker compose](https://docs.docker.com/compose/reference/) to build
6464
the JupyterHub Docker image:
6565

6666
```bash
67-
docker-compose build
67+
docker compose build
6868
```
6969

7070
## Customisation: Jupyter Notebook Image
@@ -85,14 +85,14 @@ JupyterHub may timeout if the image being pulled is large, so it is better to
8585
pull the image to the host before running JupyterHub.
8686

8787
This deployment defaults to the
88-
[jupyter/base-notebook](https://hub.docker.com/r/jupyter/base-notebook/)
88+
[quay.io/jupyter/base-notebook](https://quay.io/repository/jupyter/base-notebook)
8989
Notebook image, which is built from the `base-notebook`
9090
[Docker stacks](https://github.com/jupyter/docker-stacks).
9191

9292
You can pull the image using the following command:
9393

9494
```bash
95-
docker pull jupyter/base-notebook:latest
95+
docker pull quay.io/jupyter/base-notebook:latest
9696
```
9797

9898
## Run JupyterHub
@@ -102,15 +102,15 @@ Run the JupyterHub container on the host.
102102
To run the JupyterHub container in detached mode:
103103

104104
```bash
105-
docker-compose up -d
105+
docker compose up -d
106106
```
107107

108108
Once the container is running, you should be able to access the JupyterHub console at `http://localhost:8000`.
109109

110110
To bring down the JupyterHub container:
111111

112112
```bash
113-
docker-compose down
113+
docker compose down
114114
```
115115

116116
---
@@ -166,8 +166,8 @@ Suppose you have the following running containers:
166166
docker ps --format "table {{.ID}}\t{{.Image}}\t{{.Names}}"
167167

168168
CONTAINER ID IMAGE NAMES
169-
bc02dd6bb91b jupyter/minimal-notebook jupyter-jtyberg
170-
7b48a0b33389 jupyterhub jupyterhub
169+
bc02dd6bb91b quay.io/jupyter/minimal-notebook jupyter-jtyberg
170+
7b48a0b33389 quay.io/jupyterhub jupyterhub
171171
```
172172

173173
In this deployment, the user's notebook directories (`/home/jovyan/work`) are backed by Docker volumes.
@@ -185,7 +185,7 @@ docker run --rm \
185185
-u root \
186186
-v /tmp:/backups \
187187
-v jtyberg:/notebooks \
188-
jupyter/minimal-notebook \
188+
quay.io/jupyter/minimal-notebook \
189189
tar cvf /backups/jtyberg-backup.tar /notebooks
190190
```
191191

basic-example/Dockerfile.jupyterhub

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Copyright (c) Jupyter Development Team.
22
# Distributed under the terms of the Modified BSD License.
33
ARG JUPYTERHUB_VERSION
4-
FROM jupyterhub/jupyterhub:$JUPYTERHUB_VERSION
4+
FROM quay.io/jupyterhub/jupyterhub:$JUPYTERHUB_VERSION
55

66
# Install dockerspawner, nativeauthenticator
77
# hadolint ignore=DL3013

basic-example/docker-compose.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Copyright (c) Jupyter Development Team.
22
# Distributed under the terms of the Modified BSD License.
33

4-
# JupyterHub docker-compose configuration file
4+
# JupyterHub docker compose configuration file
55
version: "3"
66

77
services:
@@ -32,7 +32,7 @@ services:
3232
# All containers will join this network
3333
DOCKER_NETWORK_NAME: jupyterhub-network
3434
# JupyterHub will spawn this Notebook image for users
35-
DOCKER_NOTEBOOK_IMAGE: jupyter/base-notebook:latest
35+
DOCKER_NOTEBOOK_IMAGE: quay.io/jupyter/base-notebook:latest
3636
# Notebook directory inside user image
3737
DOCKER_NOTEBOOK_DIR: /home/jovyan/work
3838

0 commit comments

Comments
 (0)