Skip to content

Commit 31ed6fa

Browse files
authored
Merge pull request #130 from krassowski/fix-missing-jep
Fix missing JEPs, move `kernel-subshells` to follow convention
2 parents dac7ff2 + c3bcc7f commit 31ed6fa

File tree

17 files changed

+105
-62
lines changed

17 files changed

+105
-62
lines changed

.github/workflows/docs.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ jobs:
2121
- uses: actions/checkout@v2
2222

2323
# Install dependencies
24-
- name: Set up Python 3.7
24+
- name: Set up Python 3.9
2525
uses: actions/setup-python@v1
2626
with:
27-
python-version: 3.7
27+
python-version: 3.9
2828

2929
- name: Build the docs
3030
run: |

.readthedocs.yaml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
version: 2
2+
3+
build:
4+
os: ubuntu-22.04
5+
tools:
6+
python: "3.9"
7+
8+
sphinx:
9+
configuration: conf.py
10+
11+
python:
12+
install:
13+
- requirements: requirements.txt

jep-process-v2/jep-process-v2.md renamed to 104-jep-process-v2/jep-process-v2.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ title: Jupyter Enhancement Proposal
33
authors: |
44
Jason Grout ([jason@jasongrout.org](mailto:jason@jasongrout.org)), Safia Abdalla ([safia@safia.rocks](mailto:safia@safia.rocks)), John Lam ([jflam@microsoft.com](mailto:jflam@microsoft.com)), Kevin M. McCormick ([mckev@amazon.com](mailto:mckev@amazon.com)), Pierre Brunelle ([brunep@amazon.com](mailto:brunep@amazon.com)), Paul Ivanov ([pi@berkeley.edu](mailto:pi@berkeley.edu))
55
issue-number: 27
6-
pr-number: 29
6+
pr-number: 29, 104
77
date-started: "2019-02-23"
88
last-update: "2023-10-10"
99
type: P - Process
File renamed without changes.

kernelspec-spec/kernelspec-spec.md renamed to 105-kernelspec-spec/kernelspec-spec.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
title: kernelspec specification
33
authors: Johan Mabille
44
issue-number: XX
5-
pr-number: [#105](https://github.com/jupyter/enhancement-proposals/pull/105)
5+
pr-number: 105
66
date-started: "2023-04-19"
77
---
88

connectionfile-spec/connectionfile-spec.md renamed to 106-connectionfile-spec/connectionfile-spec.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
title: connection file specification
33
authors: Johan Mabille
44
issue-number: XX
5-
pr-number: XX
5+
pr-number: 106
66
date-started: "2023-04-19"
77
---
88

118-restart-clarification/restart-clarification.md

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ pr-number: [#118](https://github.com/jupyter/enhancement-proposals/pull/118)
66
date-started: 2023-08-23
77
---
88

9-
# Summary
9+
# Restart Clarification
10+
11+
## Summary
1012

1113
The jupyter client protocol around what "restart" means is ambiguous. Per Jupyter Client's [kernel shutdown documention](https://jupyter-client.readthedocs.io/en/latest/messaging.html#kernel-shutdown), the only guidance is:
1214
> 'restart' : bool # False if final shutdown, or True if shutdown precedes a restart
@@ -16,13 +18,13 @@ This has led to a situation where certain jupyter subprojects (e.g. enterprise g
1618
We propose to clarify this to always mean "restart-in-place", that is only restart the kernel itself. For
1719
most usage of Jupyter, this change is a no-op as subprocess kernels already act like this.
1820

19-
# Motivation
21+
## Motivation
2022

2123
This greatly improves the usability of remote kernels whose startup includes scheduling. By making this change,
2224
restarts for remote kernels will be nearly as fast as those of local kernels. It also matches what we
2325
believe to be the mental model of users when they click "restart".
2426

25-
# Guide-level explanation
27+
## Guide-level explanation
2628

2729
The [protocol](https://jupyter-client.readthedocs.io/en/latest/messaging.html#kernel-shutdown) would describe
2830
restart as optimally preserving as many resources outside the kernel as possible (e.g. restarting only the kernel process and its subprocess *not* any parent process).
@@ -32,12 +34,12 @@ When the kernel is a toplevel process (e.g. local kernels), there is no change.
3234
When the kernel is not a toplevel process (e.g. when used in Enterprise Gateway), restart often means only the kernel restarts. To restart the whole progress group, the stop and start messages could be used. It's up to UIs
3335
for how to display this difference (if any).
3436

35-
# Reference-level explanation
37+
## Reference-level explanation
3638

3739
The `jupyter-client` messaging page would be updated to indicate this nuance. Any implementations that
3840
treat restart differently would be updated to match this clarification.
3941

40-
# Rationale and alternatives
42+
## Rationale and alternatives
4143

4244
A new message could be added, as proposed in the pre-JEP. In the [Jupyter Server meeting](https://github.com/jupyter-server/team-compass/issues/45#issuecomment-1682582186),
4345
we concluded that is is likely most users want restart to only restart the kernel and not potentially reschedule resources. Therefore, a new message was not the best option.
@@ -46,15 +48,15 @@ is the same as a hard restart since it is the toplevel kernel process.
4648

4749
For users that want a hard restart, a stop followed by a start continues to be available. While this may be less convenient, a UI can trivially hide this two call process from the user.
4850

49-
# Prior art
51+
## Prior art
5052

5153
N/A
5254

53-
# Unresolved questions
55+
## Unresolved questions
5456

5557
Only the exact wording changes as proposed in [jupyter_client](https://github.com/jupyter/jupyter_client/pull/966).
5658

57-
# Future possibilities
59+
## Future possibilities
5860

5961
We would make a service that implements a "hard restart" as discussed in the jupyter-server meeting.
6062
No one on the meeting had an immediate use case for it.

80-kernel-info/kernel-info.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Support kernel\_info request on the control channel
1+
# Support `kernel_info` request on the control channel
22

33
## Problem
44

@@ -14,9 +14,9 @@ We propose to state in the Jupyter Messaging Protocol that the `kernel_info` req
1414

1515
### Impact on existing implementations
1616

17-
This JEP impacts kernels since it requires them to support receiving 'kernel\_info\_request' on the control channel in addition to receiving them on the shell channel.
17+
This JEP impacts kernels since it requires them to support receiving `kernel_info_request` on the control channel in addition to receiving them on the shell channel.
1818

19-
It also has an impact on the Jupyter Server. For example, the reference implementation of Jupyter Server will attempt to send a a `kernel_info` request on both channels and listen for a response from _either_ channel. Any response informs the UI that the kernel is connected.
19+
It also has an impact on the Jupyter Server. For example, the reference implementation of Jupyter Server will attempt to send a a `kernel_info` request on both channels and listen for a response from _either_ channel. Any response informs the UI that the kernel is connected.
2020

2121
## Relevant Resources (GitHub repositories, Issues, PRs)
2222

0 commit comments

Comments
 (0)