Skip to content

Commit 782bd33

Browse files
committed
Add defaultServiceAccountName option in Helm
1 parent ffebbaf commit 782bd33

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

docs/source/operators/deploy-kubernetes.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,11 +488,12 @@ can override them with helm's `--set` or `--values` options. Always use `--set`
488488
| `authToken` | Optional authorization token passed in all requests (see --EnterpriseGatewayApp.auth_token) | `nil` |
489489
| `kernel.clusterRole` | Kernel cluster role created by this chart. Used if no KERNEL_NAMESPACE is provided by client. | `kernel-controller` |
490490
| `kernel.shareGatewayNamespace` | Will start kernels in the same namespace as EG if True. | `false` |
491+
| `kernel.defaultServiceAccountName` | Service account name to use for kernel pods when no service account is specified. This service account should exist in the namespace where kernel pods are launched. | `default` |
491492
| `kernel.launchTimeout` | Timeout for kernel launching in seconds. | `60` |
492493
| `kernel.cullIdleTimeout` | Idle timeout in seconds. Default is 1 hour. | `3600` |
493494
| `kernel.cullConnected` | Whether to cull idle kernels that still have clients connected. | `false` |
494495
| `kernel.allowedKernels` | List of kernel names that are available for use. | `{r_kubernetes,...}` (see `values.yaml`) |
495-
| `kernel.defaultKernelName` | Default kernel name should be something from the allowedKernels | `python-kubernetes` |
496+
| `kernel.defaultKernelName` | Default kernel name should be something from the allowedKernels | `python_kubernetes` |
496497
| `kernelspecs.image` | Optional custom data image containing kernelspecs to use. Cannot be used with NFS enabled. | `nil` |
497498
| `kernelspecs.imagePullPolicy` | Kernelspecs image pull policy. | `Always` |
498499
| `nfs.enabled` | Whether NFS-mounted kernelspecs are enabled. Cannot be used with `kernelspecs.image` set. | `false` |

etc/kubernetes/helm/enterprise-gateway/templates/deployment.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ spec:
7777
value: {{ toJson .Values.kernel.allowedKernels | squote }}
7878
- name: EG_DEFAULT_KERNEL_NAME
7979
value: {{ .Values.kernel.defaultKernelName }}
80+
- name: EG_DEFAULT_KERNEL_SERVICE_ACCOUNT_NAME
81+
value: {{ .Values.kernel.defaultServiceAccountName }}
8082
# Optional authorization token passed in all requests
8183
{{- if .Values.authToken }}
8284
- name: EG_AUTH_TOKEN

etc/kubernetes/helm/enterprise-gateway/values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,9 @@ kernel:
108108
- spark_python_operator
109109
# Default kernel name should be something from the allowedKernels
110110
defaultKernelName: python_kubernetes
111+
# Service account name to use for kernel pods when no service account is specified.
112+
# This service account should exist in the namespace where kernel pods are launched.
113+
defaultServiceAccountName: default
111114

112115
kernelspecs:
113116
# Optional custom data image containing kernelspecs to use.

0 commit comments

Comments
 (0)