Fix more lint errors

Author: IsabelParedes

src/controls.ts

@@ -2,15 +2,15 @@ import { GUI } from 'dat.gui';
 import { Color } from 'three';
 import { URDFJoint } from 'urdf-loader';
 
-interface Joints {
+interface IJoints {
   [name: string]: URDFJoint;
 }
 
 export class URDFControls extends GUI {
   private _workspaceFolder: any;
   private _sceneFolder: any;
   private _jointsFolder: any;
-  private _workingPath: string = '';
+  private _workingPath = '';
 
   controls: any = {
     path: {},
@@ -56,16 +56,18 @@ export class URDFControls extends GUI {
     return this._jointsFolder;
   }
 
-  private _isEmpty(obj: Object): Boolean {
+  private _isEmpty(obj: object): boolean {
     return Object.keys(obj).length === 0;
   }
 
-  createWorkspaceControls(workingPath: string = '') {
+  createWorkspaceControls(workingPath = '') {
     if (this._isEmpty(this.controls.path)) {
       this._workingPath = workingPath;
       const workspaceSettings = {
         Path: this._workingPath,
-        'set path': () => {}
+        'set path': () => {
+          console.debug('set path');
+        }
       };
       this._workspaceFolder.add(workspaceSettings, 'Path');
       this.controls.path = this._workspaceFolder.add(
@@ -125,7 +127,7 @@ export class URDFControls extends GUI {
     return colorArray;
   }
 
-  createJointControls(joints: Joints) {
+  createJointControls(joints: IJoints) {
     if (this._isEmpty(this.controls.joints)) {
       Object.keys(joints).forEach((name: string) => {
         // Skip joints which should not be moved

src/index.ts

@@ -165,7 +165,10 @@ const extension: JupyterFrontEndPlugin<void> = {
       // FIXME: Property 'push' does not exist on type 'readonly string[]'.
       // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
-      languageRegistry.findByMIME('text/xml')?.extensions?.push('urdf', 'xacro');
+      languageRegistry.findByMIME('text/xml')?.extensions?.push('urdf');
+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+      // @ts-ignore
+      languageRegistry.findByMIME('text/xml')?.extensions?.push('xacro');
     }
   }
 };

src/layout.ts

@@ -7,7 +7,7 @@ import { URDFControls } from './controls';
 import { URDFRenderer } from './renderer';
 import { URDFLoadingManager } from './robot';
 
-interface URDFColors {
+interface IURDFColors {
   sky: Color;
   ground: Color;
 }
@@ -19,7 +19,7 @@ export class URDFLayout extends PanelLayout {
   private _host: HTMLElement;
   private _controlsPanel: URDFControls;
   private _renderer: URDFRenderer;
-  private _colors: URDFColors;
+  private _colors: IURDFColors;
   private _loader: URDFLoadingManager;
 
   /**
@@ -130,7 +130,9 @@ export class URDFLayout extends PanelLayout {
    * Set the callback functions for each of item in the controls panel
    */
   private _setControls(): void {
-    if (!this._loader.isReady) return;
+    if (!this._loader.isReady) {
+      return;
+    }
 
     this._setPathControls();
     this._setSceneControls();

src/renderer.ts

@@ -18,7 +18,7 @@ export class URDFRenderer extends THREE.WebGLRenderer {
   private _controls: OrbitControls;
   private _colorSky = new THREE.Color();
   private _colorGround = new THREE.Color();
-  private _robotIndex: number = -1;
+  private _robotIndex = -1;
 
   constructor(
     colorSky = new THREE.Color(0x263238),
@@ -160,7 +160,7 @@ export class URDFRenderer extends THREE.WebGLRenderer {
     this.redraw();
   }
 
-  setGridHeight(height: number = 0): void {
+  setGridHeight(height = 0): void {
     const gridIndex = this._scene.children
       .map(i => i.type)
       .indexOf('GridHelper');

src/robot.ts

@@ -24,8 +24,8 @@ class XacroLoaderWithPath extends XacroLoader {
 export class URDFLoadingManager extends LoadingManager {
   private _urdfLoader: URDFLoader;
   private _xacroLoader: XacroLoaderWithPath;
-  private _workingPath: string = '';
-  private _robotString: string = '';
+  private _workingPath = '';
+  private _robotString = '';
   private _robotModel = {} as URDFRobot;
   private _isReady = false;
 
@@ -61,7 +61,7 @@ export class URDFLoadingManager extends LoadingManager {
       PageConfig.getBaseUrl() + '/files' + this._workingPath;
   }
 
-  setRobot(robotString: string = ''): void {
+  setRobot(robotString = ''): void {
     this._robotString = robotString || this._robotString;
 
     if (robotString.includes('xacro')) {