Standardize naming

Author: IsabelParedes

src/factory.ts

@@ -4,26 +4,26 @@ import {
   DocumentModel
 } from '@jupyterlab/docregistry';
 
-import { UrdfWidget, UrdfPanel } from './widget';
+import { URDFWidget, URDFPanel } from './widget';
 
 /**
- * A widget factory to create new instances of UrdfWidgets
+ * A widget factory to create new instances of URDFWidgets
  */
-export class UrdfWidgetFactory extends ABCWidgetFactory<
-  UrdfWidget,
+export class URDFWidgetFactory extends ABCWidgetFactory<
+  URDFWidget,
   DocumentModel
 > {
   constructor(options: DocumentRegistry.IWidgetFactoryOptions) {
     super(options);
   }
 
-  // Create new UrdfWidget given a context (file info)
+  // Create new URDFWidget given a context (file info)
   protected createNewWidget(
     context: DocumentRegistry.IContext<DocumentModel>
-  ): UrdfWidget {
-    return new UrdfWidget({
+  ): URDFWidget {
+    return new URDFWidget({
       context,
-      content: new UrdfPanel(context)
+      content: new URDFPanel(context)
     });
   }
 }

src/index.ts

@@ -20,9 +20,9 @@ import { Menu } from '@lumino/widgets';
 
 import { Token } from '@lumino/coreutils';
 
-import { UrdfWidget } from './widget';
+import { URDFWidget } from './widget';
 
-import { UrdfWidgetFactory } from './factory';
+import { URDFWidgetFactory } from './factory';
 
 import { urdf_icon } from './icons';
 
@@ -33,7 +33,7 @@ import { IEditorLanguageRegistry } from '@jupyterlab/codemirror';
 const FACTORY = 'URDF Widget Factory';
 
 // Export token so other extensions can require it
-export const IUrdfTracker = new Token<IWidgetTracker<UrdfWidget>>(
+export const IURDFTracker = new Token<IWidgetTracker<URDFWidget>>(
   'urdf-tracker'
 );
 
@@ -65,7 +65,7 @@ const extension: JupyterFrontEndPlugin<void> = {
 
     // Tracker
     const namespace = 'jupyterlab-urdf';
-    const tracker = new WidgetTracker<UrdfWidget>({ namespace });
+    const tracker = new WidgetTracker<URDFWidget>({ namespace });
 
     // State restoration: reopen document if it was open previously
     if (restorer) {
@@ -80,7 +80,7 @@ const extension: JupyterFrontEndPlugin<void> = {
     }
 
     // Create widget factory so that manager knows about widget
-    const widgetFactory = new UrdfWidgetFactory({
+    const widgetFactory = new URDFWidgetFactory({
       name: FACTORY,
       fileTypes: ['urdf'],
       defaultFor: ['urdf']

src/robot.ts

@@ -79,6 +79,10 @@ export class URDFLoadingManager extends LoadingManager {
     }
   }
 
+  dispose(): void {
+    this._robotModel = {} as URDFRobot;
+  }
+
   get robotModel() {
     return this._robotModel;
   }

src/widget.ts

@@ -13,10 +13,10 @@ import { Signal } from '@lumino/signaling';
 import { URDFLayout } from './layout';
 
 /**
- * UrdfWidget: widget that represents the view for a urdf (file).
+ * URDFWidget: widget that represents the view for a urdf (file).
  */
-export class UrdfWidget extends DocumentWidget<UrdfPanel, DocumentModel> {
-  constructor(options: DocumentWidget.IOptions<UrdfPanel, DocumentModel>) {
+export class URDFWidget extends DocumentWidget<URDFPanel, DocumentModel> {
+  constructor(options: DocumentWidget.IOptions<URDFPanel, DocumentModel>) {
     super(options);
   }
 
@@ -28,13 +28,13 @@ export class UrdfWidget extends DocumentWidget<UrdfPanel, DocumentModel> {
 }
 
 /**
- * UrdfPanel: widget that contains the main view of the UrdfWidget.
+ * URDFPanel: widget that contains the main view of the URDFWidget.
  */
-export class UrdfPanel extends Panel {
+export class URDFPanel extends Panel {
   private _context: DocumentRegistry.IContext<DocumentModel>;
 
   /**
-   * Construct a UrdfPanel
+   * Construct a URDFPanel
    *
    * @param context - The documents context
    */