Skip to content

Commit 7a5928f

Browse files
committed
Clean up more
1 parent d5926f7 commit 7a5928f

File tree

2 files changed

+4
-71
lines changed

2 files changed

+4
-71
lines changed

ipynao/nao_robot.py

Lines changed: 4 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -63,67 +63,30 @@ class NaoRobotWidget(DOMWidget):
6363
connected = Unicode("Disconnected").tag(sync=True)
6464
status = Unicode("Not busy").tag(sync=True)
6565
response = Unicode("").tag(sync=True)
66-
counter = Integer(0).tag(sync=True, read_only=True)
66+
counter = Integer(0).tag(sync=True)
6767
js_response = None
6868

69+
6970
def __init__(self, **kwargs):
7071
super().__init__(**kwargs)
7172
self.on_msg(self._handle_frontend_msg)
72-
# self.observe(self._handle_value_change, names="status")
73+
7374

7475
def _handle_frontend_msg(self, model, msg, buffer):
7576
print("Received frontend msg: ", msg)
7677
self.js_response = msg
7778

78-
def _handle_value_change(self, change):
79-
print("HANDLE HANDLE HANDLE", change)
80-
self.response = change['new']
8179

8280
def wait_for_change(widget, value_name):
8381
future = asyncio.Future()
8482

8583
def get_value_change(change):
8684
widget.unobserve(get_value_change, names=value_name)
87-
# future.set_result(change['new'])
8885
future.set_result(widget.js_response)
8986

9087
widget.observe(get_value_change, names=value_name)
91-
return future
92-
93-
async def set_after(self, future, delay):
94-
95-
for i in range(25):
96-
print(i, " Sleep a blink > ", self.response, '< response')
97-
await asyncio.sleep(delay)
98-
if (self.response != ''):
99-
print("setting the future ", i)
100-
future.set_result(self.response)
101-
break
102-
103-
self.response = ''
104-
105-
106-
async def go_sleep(self, out, tSeconds=2):
107-
data = {}
108-
data["command"] = str("goSleep")
109-
data["tSeconds"] = tSeconds
110-
self.send(data)
111-
112-
try:
113-
await self.wait_for_change('counter')
114-
except Exception as e:
115-
print('Something wrong: ', e)
116-
out.append_stdout('something wrong' + str(e))
117-
118-
119-
# loop = asyncio.get_running_loop()
120-
# future = loop.create_future()
121-
122-
# print("Go sleep ...")
123-
# loop.create_task(self.set_after(future, 0.5))
88+
return future
12489

125-
# return future
126-
12790

12891
def connect(self, ip_address="nao.local", port="80"):
12992
data = {}

src/widget.ts

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -167,37 +167,9 @@ export class NaoRobotModel extends DOMWidgetModel {
167167
this.save_changes();
168168
}
169169

170-
async goSleep() {
171-
this.changeStatus("Going to sleep.");
172-
const sleep = (ms: number) => new Promise((r) => setTimeout(r, ms));
173-
174-
const motion = await this.qiSession.service("ALMotion");
175-
let joints;
176-
joints = await motion.getRobotConfig();
177-
console.log('JOINTS: ', joints);
178-
this.set('status', joints.toString());
179-
180-
181-
await sleep(3000);
182-
this.set('counter', this.get('counter') + 1);
183-
184-
185-
this.changeStatus("Slept for a second");
186-
this.set('status', 'RES: 1 second');
187-
this.save_changes();
188-
// this.send('JS: first message');
189-
190-
}
191-
192170
private async onCommand(commandData: any, buffers: any) {
193-
console.log('REMOVE onCommand', commandData);
194171
const cmd = commandData['command'];
195172

196-
if (cmd === "goSleep") {
197-
await this.goSleep();
198-
return;
199-
}
200-
201173
switch (cmd) {
202174
case 'connect':
203175
await this.connect(commandData['ipAddress'], commandData['port']);
@@ -212,7 +184,6 @@ export class NaoRobotModel extends DOMWidgetModel {
212184
break;
213185

214186
case 'callService':
215-
console.log('RECEIVING COMMAND FOR SERVICE');
216187
await this.callService(
217188
commandData['service'],
218189
commandData['method'],
@@ -222,7 +193,6 @@ export class NaoRobotModel extends DOMWidgetModel {
222193
break;
223194
}
224195

225-
console.log('End of OnCommand');
226196
}
227197

228198
static serializers: ISerializers = {

0 commit comments

Comments
 (0)