Skip to content

Commit 0ab75c3

Browse files
committed
Rename some vars
1 parent 071809f commit 0ab75c3

File tree

1 file changed

+29
-24
lines changed

1 file changed

+29
-24
lines changed

src/qimessaging.ts

Lines changed: 29 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -25,51 +25,52 @@ export class QiSession {
2525
let _sigs = new Array();
2626
let _idm = 0;
2727

28-
interface MetaObject {
28+
interface replyType {
2929
__MetaObject?: any;
3030
}
3131

32+
3233
_socket.on('reply', function (data: any) {
3334
console.log('DBG Emile qim reply');
3435
// @ts-ignore
3536
window['datata'] = data;
36-
console.log("here's the datata");
37+
console.log("here's the datata", data); // REMOVE
3738

3839
let idm = data['idm'];
3940
if (data['result'] != null && data['result']['metaobject'] != undefined) {
4041
// let o = new Object();
41-
let o: MetaObject = {
42+
let replyObject: replyType = {
4243
__MetaObject: data['result']['metaobject'],
4344
};
4445

4546
let pyobj = data['result']['pyobject'];
4647
_sigs[pyobj] = new Array();
47-
let methods = o.__MetaObject['methods'];
48+
let methods = replyObject.__MetaObject['methods'];
4849

4950
for (let i in methods) {
5051
let methodName = methods[i]['name'];
5152
// @ts-ignore
52-
o[methodName] = createMetaCall(pyobj, methodName, 'data');
53+
replyObject[methodName] = createMetaCall(pyobj, methodName, 'data');
5354
}
54-
let signals = o.__MetaObject['signals'];
55+
let signals = replyObject.__MetaObject['signals'];
5556
for (let i in signals) {
5657
let signalName = signals[i]['name'];
5758
// @ts-ignore
58-
o[signalName] = createMetaSignal(pyobj, signalName, false);
59+
replyObject[signalName] = createMetaSignal(pyobj, signalName, false);
5960
}
60-
let properties = o.__MetaObject['properties'];
61+
let properties = replyObject.__MetaObject['properties'];
6162
for (let i in properties) {
6263
let propertyName = properties[i]['name'];
6364
// @ts-ignore
64-
o[propertyName] = createMetaSignal(pyobj, propertyName, true);
65+
replyObject[propertyName] = createMetaSignal(pyobj, propertyName, true);
6566
}
66-
_dfd[idm].resolve(o);
67+
_dfd[idm].resolve(replyObject);
6768

68-
console.log('What is this o');
69+
console.log('What is this o'); // REMOVE
6970
// @ts-ignore
70-
window['ooo'] = o;
71+
window['ooo'] = replyObject; // REMOVE
7172
// @ts-ignore
72-
window['dfd'] = _dfd;
73+
window['dfd'] = _dfd; // REMOVE
7374
} else {
7475
if (_dfd[idm].__cbi != undefined) {
7576
let cbi = _dfd[idm].__cbi;
@@ -79,24 +80,27 @@ export class QiSession {
7980
}
8081
delete _dfd[idm];
8182
});
83+
8284
_socket.on('error', function (data: any) {
8385
console.log('DBG Emile qim error');
8486
if (data['idm'] != undefined) {
8587
_dfd[data['idm']].reject(data['result']);
8688
delete _dfd[data['idm']];
8789
}
8890
});
91+
8992
_socket.on('signal', function (data: any) {
90-
// console.log("DBG Emile qim signal"); REMOVE
93+
console.log("DBG Emile qim signal");
9194
let res = data['result'];
9295
let callback = _sigs[res['obj']][res['signal']][res['link']];
9396
if (callback != undefined) {
9497
// @ts-ignore
9598
callback.apply(this, res['data']);
9699
}
97100
});
101+
98102
_socket.on('disconnect', function (data: any) {
99-
// console.log("DBG Emile qim disconnect"); REMOVE
103+
console.log("DBG Emile qim disconnect");
100104
for (let idm in _dfd) {
101105
_dfd[idm].reject('Call ' + idm + ' canceled: disconnected');
102106
delete _dfd[idm];
@@ -107,6 +111,7 @@ export class QiSession {
107111
console.log('DBG Isabel disconnected');
108112
}
109113
});
114+
110115
function createMetaCall(obj: any, member: any, data: any) {
111116
return function () {
112117
let idm = ++_idm;
@@ -125,17 +130,17 @@ export class QiSession {
125130
};
126131
}
127132

128-
interface sObject {
133+
interface signalType {
129134
connect?: any;
130135
disconnect?: any;
131136
setValue?: any;
132137
value?: any;
133138
}
139+
134140
function createMetaSignal(obj: any, signal: any, isProperty: any) {
135-
// let s = new Object();
136-
let s: sObject = {};
141+
let signalObject: signalType = {};
137142
_sigs[obj][signal] = new Array();
138-
s.connect = function (cb: any) {
143+
signalObject.connect = function (cb: any) {
139144
return createMetaCall(obj, signal, {
140145
obj: obj,
141146
signal: signal,
@@ -145,27 +150,27 @@ export class QiSession {
145150
};
146151

147152
// @ts-ignore
148-
s.disconnect = function (l) {
153+
signalObject.disconnect = function (l) {
149154
delete _sigs[obj][signal][l];
150155
// @ts-ignore
151156
return createMetaCall(obj, signal, 'data')('disconnect', l);
152157
};
153158
if (!isProperty) {
154-
return s;
159+
return signalObject;
155160
}
156-
s.setValue = function () {
161+
signalObject.setValue = function () {
157162
let args = Array.prototype.slice.call(arguments, 0);
158163
return createMetaCall(obj, signal, 'data').apply(
159164
this,
160165
// @ts-ignore
161166
['setValue'].concat(args)
162167
);
163168
};
164-
s.value = function () {
169+
signalObject.value = function () {
165170
// @ts-ignore
166171
return createMetaCall(obj, signal, 'data')('value');
167172
};
168-
return s;
173+
return signalObject;
169174
}
170175

171176
this.service = createMetaCall('ServiceDirectory', 'service', 'data');

0 commit comments

Comments
 (0)