ParameterResolution for constructor argument injection for ParameterizedClass

[sebersole]

I've started playing around with ParameterizedTest and ParameterizedClass a bit in Hibernate test suite. We have already built an infrastructure around extensions including ParameterResolvers. E.g., this let's us do things like:

@DomainModel(annotatedClasses=SomeEntity.class)
@SessionFactory(....)
class SomeTests {
    @Test
    void someTest(SessionFactoryScope scope) {
        SessionFactory factory = scope.getSessionFactory();
        scope.inTransaction( (session) -> {
            // do some stuff...
        } );
    }
}

(@SessionFactory registers a ParameterResolver)

Now, as I start incorporating ParameterizedClass paired with constructor-injection, I have stuff like:

@DomainModel(annotatedClasses=SomeEntity.class)
@SessionFactory(....)
@ParameterizedClass
@ValueSource(strings = { "a", "b", "c" })
class SomeTests {
    private String param;

    SomeTests(String param) {
        this.param = param;
    }

    @Test
    void someTest(SessionFactoryScope scope) {
        SessionFactory factory = scope.getSessionFactory();
        scope.inTransaction( (session) -> {
            // do some stuff...
        } );
    }
}

Which works great. But I (naively) thought I should be able to do:

@DomainModel(annotatedClasses=SomeEntity.class)
@SessionFactory(....)
@ParameterizedClass
@ValueSource(strings = { "a", "b", "c" })
class SomeTests {
    private final String param;
    private final SessionFactoryScope factoryScope;

    SomeTests(String param, SessionFactoryScope factoryScope) {
        this.param = param;
        this.factoryScope = factoryScope;
    }

    @Test
    void someTest() {
        SessionFactory factory = this.factoryScope.getSessionFactory();
        this.factoryScope.inTransaction( (session) -> {
            // do some stuff...
        } );
    }
}

Just to throw out as a thought.

[marcphilipp]

@sebersole That should already work. Are you getting an exception?

[sebersole]

Let me try to reproduce it again. I rewrote that test and moved on

[sebersole]

org.junit.jupiter.api.extension.ParameterResolutionException: Discovered multiple competing ParameterResolvers for parameter [org.hibernate.testing.orm.junit.SessionFactoryScope arg0] in constructor [public org.hibernate.orm.test.ParameterizedTestClassTests(org.hibernate.testing.orm.junit.SessionFactoryScope)]: org.hibernate.testing.orm.junit.SessionFactoryScopeParameterResolver@79a1728c, org.junit.jupiter.params.ClassTemplateConstructorParameterResolver@a7f0ab6

The stacktrace does not seem useful, though I can paste it if you want

[sebersole]

@ExtendWith( SessionFactoryExtension.class )
@ExtendWith( SessionFactoryParameterResolver.class )
@ExtendWith( SessionFactoryScopeParameterResolver.class )
public @interface SessionFactory {...}