Skip to content

Commit 6f0eb50

Browse files
committed
[About] [Dashboard] move GitHub button from Dashboard to About
1 parent 2fa1beb commit 6f0eb50

File tree

2 files changed

+27
-25
lines changed

2 files changed

+27
-25
lines changed

client/src/interface/components/About/index.js

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ import LinkForNewWindow from '../LinkToNewWindow';
5050
import iCtrlQRCode from './iCtrlQRCode.svg';
5151
import './index.css';
5252
import ICtrlVoiceButton from '../iCtrlVoiceButton/iCtrlVoiceButton';
53+
import GitHubButton from 'react-github-btn';
54+
import {openInNewWindow} from '../../../actions/utils';
5355

5456
const AboutSection = (props) => (
5557
<>
@@ -90,8 +92,29 @@ export default class About extends React.Component {
9092
return <Dialog open={true} fullWidth={true} maxWidth={'md'}>
9193
<DialogTitle>
9294
<div style={{display: 'flex', alignItems: 'center'}}>
93-
<span>About iCtrl {version && `(v${version})`}</span>
94-
<ICtrlVoiceButton/>
95+
<div style={{flexGrow: 1, display: 'flex', alignItems: 'center'}}>
96+
<span style={{
97+
marginLeft: '16px',
98+
marginRight: '8px',
99+
fontWeight: 'bold',
100+
fontSize: '24px',
101+
}}>About iCtrl {version && `(v${version})`}</span>
102+
<ICtrlVoiceButton/>
103+
</div>
104+
<div onClick={(ev) => {
105+
openInNewWindow(
106+
'https://github.com/junhaoliao/iCtrl', ev);
107+
}}>
108+
<GitHubButton
109+
href="https://github.com/junhaoliao/iCtrl"
110+
data-color-scheme="no-preference: light_high_contrast; light: light_high_contrast; dark: light_high_contrast;"
111+
data-show-count="true"
112+
aria-label="Star junhaoliao/iCtrl on GitHub"
113+
data-size={'large'}
114+
>
115+
Star
116+
</GitHubButton>
117+
</div>
95118
</div>
96119
</DialogTitle>
97120
<DialogContent style={{maxHeight: '630px'}}>

client/src/interface/pages/Dashboard/index.js

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,7 @@ import axios from 'axios';
4242

4343
import logo from '../../../icons/logo.webp';
4444
import ictrlLogo from '../../../icons/logo.webp';
45-
import {openInNewWindow} from '../../../actions/utils';
4645
import About from '../../components/About';
47-
import GitHubButton from 'react-github-btn';
4846
import ResetVNCDialog from '../../components/ResetVNCDialog';
4947
import TrafficLights from '../../components/TrafficLights/TrafficLights';
5048
import Session from './Session';
@@ -177,28 +175,10 @@ export default class Dashboard extends React.Component {
177175
sx={{flexGrow: 1}}>
178176
iCtrl Dashboard
179177
</Typography>
180-
<div
181-
className={'titlebar-buttons'}
182-
onClick={(ev) => {
183-
openInNewWindow(
184-
'https://github.com/junhaoliao/iCtrl', ev);
185-
}}
186-
style={{
187-
marginTop: '5px',
188-
marginRight: '16px',
189-
overflowX: 'auto',
190-
overflowY: 'hidden',
191-
}}>
192-
<GitHubButton
193-
href="https://github.com/junhaoliao/iCtrl"
194-
data-color-scheme="no-preference: light_high_contrast; light: light_high_contrast; dark: light_high_contrast;"
195-
data-show-count="true"
196-
aria-label="Star junhaoliao/iCtrl on GitHub">Star</GitHubButton>
197-
198-
</div>
199178
<Tooltip title="About iCtrl"
200179
className={'titlebar-buttons'}>
201-
<IconButton onClick={this.handleAboutOpen}
180+
<IconButton disabled={loading_sessions}
181+
onClick={this.handleAboutOpen}
202182
size={'large'}>
203183
<InfoIcon style={{color: 'white'}}
204184
fontSize="large"/>
@@ -282,5 +262,4 @@ export default class Dashboard extends React.Component {
282262
</>
283263
);
284264
}
285-
286265
}

0 commit comments

Comments
 (0)