Skip to content

Commit 28f5a33

Browse files
authored
Fix a problem with host.json being ignored (#14)
* #10 Remove telemetry client. * Remove unnecessary dependencies. * Upgrade `Microsoft.Azure.Functions.Extensions` to latest version. * Upgrade `Autofac.Extensions.DependencyInjection` to latest version. * Add `nuget` publish key
1 parent 629de75 commit 28f5a33

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ jobs:
7272

7373
- name: Publish Package
7474
id: "publish"
75+
env:
76+
NUGET_KEY: ${{ secrets.NUGET_KEY }} # Environment token
7577
run: |
7678
for f in $(find ./ -name '*.nupkg'); do
7779
echo "Pushing $f...";

Autofac.Extensions.DependencyInjection.AzureFunctions/AppSettingsExtensions.cs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
using Microsoft.Extensions.DependencyInjection.Extensions;
55
using System;
66
using System.IO;
7-
using System.Linq;
87
using System.Reflection;
98

109
namespace Autofac.Extensions.DependencyInjection.AzureFunctions
@@ -51,10 +50,13 @@ public static IFunctionsHostBuilder UseAppSettings(this IFunctionsHostBuilder ho
5150
{
5251
var configurationBuilder = new ConfigurationBuilder() as IConfigurationBuilder;
5352

54-
var descriptor = hostBuilder.Services.FirstOrDefault(d => d.ServiceType == typeof(IConfiguration));
55-
if (descriptor?.ImplementationInstance is IConfiguration configRoot)
53+
using (var temporaryServiceProvider = hostBuilder.Services.BuildServiceProvider())
5654
{
57-
configurationBuilder.AddConfiguration(configRoot);
55+
var configRoot = temporaryServiceProvider.GetService<IConfiguration>();
56+
if (configRoot != null)
57+
{
58+
configurationBuilder.AddConfiguration(configRoot);
59+
}
5860
}
5961

6062
configurationAction?.Invoke(configurationBuilder);

SampleAutofacFunction/host.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"applicationInsights": {
55
"samplingExcludedTypes": "Request",
66
"samplingSettings": {
7-
"isEnabled": true
7+
"isEnabled": false
88
}
99
}
1010
},

0 commit comments

Comments
 (0)