Fix param name

[klamike]

julia> using JuMP, Dualization

julia> m = Model()
A JuMP Model
├ solver: none
├ objective_sense: FEASIBILITY_SENSE
├ num_variables: 0
├ num_constraints: 0
└ Names registered in the model: none

julia> @variable m x
x

julia> @variable m p ∈ Parameter(1.0)
@constrp

julia> @constraint m x ≥ p
x - p ≥ 0

julia> @objective m Min x
x

julia> dualize(m, dual_names=DualNames())
ERROR: UndefVarError: `vi` not defined in `Dualization`

[joaquimg]

Thanks!
If you can add a test covering that I can speedup de merge.

[klamike]

In making that test I came across this conditional which doesn't seem quite right to me. Is it expected that variable_parameters is ignored when ignore_objective=true?

Dualization.jl/src/dual_model_variables.jl

Lines 123 to 135 in 42b6ad3

	parameters = if ignore_objective
	# only crossed terms (parameter times primal variable) of the objective
	# are required
	to_add = Set{MOI.VariableIndex}()
	for vec in values(primal_objective.quad_cross_parameters)
	for term in vec
	push!(to_add, term.variable)
	end
	end
	collect(to_add)
	else
	variable_parameters
	end

[klamike]

The JuMP test added in #198 covers this as well

[joaquimg]

format is failing

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.26%. Comparing base (42b6ad3) to head (4b6781c).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   92.86%   94.26%   +1.39%     
==========================================
  Files          14       14              
  Lines         743      750       +7     
==========================================
+ Hits          690      707      +17     
+ Misses         53       43      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[blegat]

Thanks!

[joaquimg]

Thanks!