[ FF7 ] ff7_widescreen_hook_init

[Moe2912]

Hello, in "ff7_widescreen_hook_init" some const values are patched with the values from "wide_viewport_x" and "wide_viewport_width". These values are being overwritten afterwards in "Widescreen::init" in case the aspect ratio is AR_WIDESCREEN_16X10 thus having patched the "wrong" values. Is this intended?

[julianxhokaxhiu]

Yes, it is intended. Why?

[Moe2912]

Thanks. Just stumbled upon it and thought that might have been a mistake.

[julianxhokaxhiu]

Sorry maybe I did not understood well your point. Maybe exposing it better what you see "wrong" might help me spot it as well. But we've already tested it for years and it's being used on the Steam Deck without any reported issue so far.

[Moe2912]

For example in line 202 you patch the constant value at address "ff7_externals.pollensalta_cold_breath_atk_enter_sub_5474F0 + 0x83" with the value from variable "wide_viewport_width" which at this time equals to it's initial value 854.

After the patching, the value is changed to 768 in "Widescreen::init" in case the aspect ratio is AR_WIDESCREEN_16X10.

My question now is: shouldn't the value at the address have been patched with 768 instead of 854? The same goes for all other instances in "ff7_widescreen_hook_init" where the values of "wide_viewport_x" and "wide_viewport_width" are used for the patches.