Throw Exception on failed remote media download

mynetx · mynetx · commit 9c9a5206d9f3 · 2016-01-06T21:20:33.000+01:00
Fix #152
diff --git a/CHANGELOG b/CHANGELOG
@@ -3,6 +3,7 @@ codebird-php - changelog
 
 3.1.0 (not yet released)
 + #143 Add support for proxy types
++ #152 Throw Exception on failed remote media download
 
 3.0.0 (2016-01-01)
 + Add unit testing suite
diff --git a/src/codebird.php b/src/codebird.php
@@ -1826,6 +1826,7 @@ protected function _fetchRemoteFile($url)
       if ($result !== false) {
         return $result;
       }
+      throw new \Exception('Downloading a remote media file failed.');
       return false;
     }
     // no cURL

Original file line number	Diff line number	Diff line change
`@@ -1826,6 +1826,7 @@ protected function _fetchRemoteFile($url)`
`1826`	`1826`	`if ($result !== false) {`
`1827`	`1827`	`return $result;`
`1828`	`1828`	`}`
	`1829`	`+ throw new \Exception('Downloading a remote media file failed.');`
`1829`	`1830`	`return false;`
`1830`	`1831`	`}`
`1831`	`1832`	`// no cURL`