all-the-icons-dired--refresh-advice doesn't check `display-graphic-p`

[mohkale]

I'm using this package in the terminal and by default icons aren't setup because this condition fails on ttys.

all-the-icons-dired/all-the-icons-dired.el

Lines 125 to 131 in fc2dfa1

	(define-minor-mode all-the-icons-dired-mode
	"Display all-the-icons icon for each files in a dired buffer."
	:lighter " all-the-icons-dired-mode"
	(when (and (derived-mode-p 'dired-mode) (display-graphic-p))
	(if all-the-icons-dired-mode
	(all-the-icons-dired--setup)
	(all-the-icons-dired--teardown))))

However all-the-icons-dired--refresh-advice which is hooked into misc dired functions eg. dired-maybe-insert-subdir doesn't check this condition so when you run it icons are forcefully inserted.

[srustamo]

@mohkale did you get this package work in tty? I see the icons, but they are all wrong in iTerm2 on macos.

[mohkale]

@srustamo

I use nerd-fonts, and replace some all-the-icons fonts with nerd-fonts. See here.