Merge pull request #85 from evcohen/stop-throwing-when-unknown-ast-nodes-are-encountered

Stop throwing errors when unknown AST nodes are encountered

Author: jessebeach

__tests__/src/getPropLiteralValue-test.js

@@ -19,17 +19,19 @@ describe('getLiteralPropValue', () => {
     assert.equal(expected, actual);
   });
 
-  it('should throw error when trying to get value from unknown node type', () => {
+  it('should not throw error when trying to get value from unknown node type', () => {
     const prop = {
       type: 'JSXAttribute',
       value: {
         type: 'JSXExpressionContainer',
       },
     };
 
-    assert.throws(() => {
+    assert.doesNotThrow(() => {
       getLiteralPropValue(prop);
     }, Error);
+
+    assert.equal(null, getLiteralPropValue(prop));
   });
 
   describe('Null', () => {

__tests__/src/getPropValue-test.js

@@ -32,9 +32,11 @@ describe('getPropValue', () => {
       },
     };
 
-    assert.throws(() => {
+    assert.doesNotThrow(() => {
       getPropValue(prop);
     }, Error);
+
+    assert.equal(null, getPropValue(prop));
   });
 
   describe('Null', () => {

src/values/expressions/index.js

@@ -80,7 +80,9 @@ export default function extract(value) {
   }
 
   if (TYPES[type] === undefined) {
-    throw new Error(errorMessage(type));
+    // eslint-disable-next-line no-console
+    console.error(errorMessage(type));
+    return null;
   }
 
   return TYPES[type](expression);
@@ -145,7 +147,9 @@ export function extractLiteral(value) {
   const { type } = expression;
 
   if (LITERAL_TYPES[type] === undefined) {
-    throw new Error(errorMessage(type));
+    // eslint-disable-next-line no-console
+    console.error(errorMessage(type));
+    return null;
   }
 
   return LITERAL_TYPES[type](expression);