fix: disallow extra properties in rule options

Author: andreww2012

lib/rules/forbid-component-props.js

@@ -131,6 +131,7 @@ module.exports = {
           },
         },
       },
+      additionalProperties: false,
     }],
   },
 

lib/rules/forbid-dom-props.js

@@ -74,6 +74,7 @@ module.exports = {
                   type: 'string',
                 },
               },
+              additionalProperties: false,
             }],
             minLength: 1,
           },

lib/rules/forbid-prop-types.js

@@ -54,7 +54,7 @@ module.exports = {
           type: 'boolean',
         },
       },
-      additionalProperties: true,
+      additionalProperties: false,
     }],
   },
 

lib/rules/function-component-definition.js

@@ -167,6 +167,7 @@ module.exports = {
             ],
           },
         },
+        additionalProperties: false,
       },
     ],
   },

lib/rules/jsx-curly-spacing.js

@@ -35,6 +35,28 @@ const messages = {
   spaceNeededBefore: 'A space is required before \'{{token}}\'',
 };
 
+const BASIC_CONFIG_SCHEMA = {
+  type: 'object',
+  properties: {
+    when: {
+      enum: SPACING_VALUES,
+    },
+    allowMultiline: {
+      type: 'boolean',
+    },
+    spacing: {
+      type: 'object',
+      properties: {
+        objectLiterals: {
+          enum: SPACING_VALUES,
+        },
+      },
+      additionalProperties: false,
+    },
+  },
+  additionalProperties: false,
+};
+
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
   meta: {
@@ -50,49 +72,25 @@ module.exports = {
 
     schema: {
       definitions: {
-        basicConfig: {
-          type: 'object',
-          properties: {
-            when: {
-              enum: SPACING_VALUES,
-            },
-            allowMultiline: {
-              type: 'boolean',
-            },
-            spacing: {
-              type: 'object',
-              properties: {
-                objectLiterals: {
-                  enum: SPACING_VALUES,
-                },
-              },
-            },
-          },
-        },
         basicConfigOrBoolean: {
-          anyOf: [{
-            $ref: '#/definitions/basicConfig',
-          }, {
+          anyOf: [BASIC_CONFIG_SCHEMA, {
             type: 'boolean',
           }],
         },
       },
       type: 'array',
       items: [{
         anyOf: [{
-          allOf: [{
-            $ref: '#/definitions/basicConfig',
-          }, {
-            type: 'object',
-            properties: {
-              attributes: {
-                $ref: '#/definitions/basicConfigOrBoolean',
-              },
-              children: {
-                $ref: '#/definitions/basicConfigOrBoolean',
-              },
+          type: 'object',
+          properties: Object.assign(BASIC_CONFIG_SCHEMA.properties, {
+            attributes: {
+              $ref: '#/definitions/basicConfigOrBoolean',
             },
-          }],
+            children: {
+              $ref: '#/definitions/basicConfigOrBoolean',
+            },
+          }),
+          additionalProperties: false,
         }, {
           enum: SPACING_VALUES,
         }],
@@ -109,6 +107,7 @@ module.exports = {
                 enum: SPACING_VALUES,
               },
             },
+            additionalProperties: false,
           },
         },
         additionalProperties: false,

lib/rules/jsx-handler-names.js

@@ -111,6 +111,7 @@ module.exports = {
               items: { type: 'string' },
             },
           },
+          additionalProperties: false,
         },
       ],
     }],

lib/rules/jsx-indent-props.js

@@ -77,6 +77,7 @@ module.exports = {
             type: 'boolean',
           },
         },
+        additionalProperties: false,
       }],
     }],
   },

lib/rules/jsx-max-props-per-line.js

@@ -53,6 +53,7 @@ module.exports = {
                 minimum: 1,
               },
             },
+            additionalProperties: false,
           },
         },
         additionalProperties: false,

lib/rules/jsx-no-literals.js

@@ -141,7 +141,7 @@ const elementOverrides = {
         { applyToNestedElements: { type: 'boolean' } },
         commonPropertiesSchema
       ),
-
+      additionalProperties: false,
     },
   },
 };

lib/rules/jsx-no-script-url.js

@@ -88,7 +88,7 @@ module.exports = {
                   type: 'boolean',
                 },
               },
-              additionalItems: false,
+              additionalProperties: false,
             },
           ],
           additionalItems: false,
@@ -103,7 +103,7 @@ module.exports = {
                   type: 'boolean',
                 },
               },
-              additionalItems: false,
+              additionalProperties: false,
             },
           ],
           additionalItems: false,