Skip to content

Feature: let optimizer remove "multiline" comments #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muuvmuuv opened this issue Jun 8, 2021 · 1 comment
Open

Feature: let optimizer remove "multiline" comments #456

muuvmuuv opened this issue Jun 8, 2021 · 1 comment
Labels
enhancement New feature or request PRs welcome

Comments

@muuvmuuv
Copy link

muuvmuuv commented Jun 8, 2021

Is your feature request related to a problem? Please describe.

As described in this issue I need multiline comments for our JSON files. So my features request is to support comments like below:

Describe the solution you'd like

{
  "features.comment.01": "------------------------------------------------",
  "features.comment.02": "------ Feature related translations below ------",
  "features.comment.03": "------------------------------------------------"
}

Describe alternatives you've considered

As described in the linked issue: support JSON comments

Current behavior

With JSON comments validator and loader cannot work and with above solution those aren't removed via optimizer.

Expected behavior

/

Additional context

I am open for alternatives.

Contribution

I want to make a pull request for this feature:
[x] Yes! 🚀 (but it may take some time, I am leaveing the company and have to train a employee)
[ ] Maybe next time

@shaharkazaz
Copy link
Collaborator

You can create a PR for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PRs welcome
Projects
None yet
Development

No branches or pull requests

2 participants