Minor quality of life fixes

- Better error passing on code editor error (set up for future
  improvements)
- Add "sourceURL" for eval-ed code so it shows up in the dev tools
  debugger

Author: jstrieb

TODO.md

@@ -32,6 +32,8 @@
   - Context menu as last child of body, gets moved by right click
   - Render tables to images to save and share screenshots
   - Settings input with numeric input and buttons on either side
+  - CSP to restrict `worker-src` (except that we don't want to block web
+    workers, only service workers)
 - Clipboard integration
   - Cut
   - Fix "put" behavior to copy formulas around to selection

src/App.svelte

@@ -211,8 +211,12 @@
 
   let codeError = $state("");
   $effect(() => {
-    evalDebounced(globals.formulaCode, (result) => {
-      codeError = result ?? "";
+    evalDebounced(globals.formulaCode, (err) => {
+      codeError = "";
+      if (err != null) {
+        codeError = `Error: ${err.message}`;
+        // TODO: Show stack trace or line nubmer of problematic code
+      }
     });
   });
 
@@ -398,7 +402,7 @@
     shadow="2px">{text}</Button
   >
 {/snippet}
-{#if innerHeight > visualBottom}
+{#if Math.abs(innerHeight - visualBottom) > 5}
   <div
     class="keyboardbar"
     style:top="calc({visualBottom}px - 2em - 2 * 0.25em - 2px)"

src/formula-functions.svelte.js

@@ -30,10 +30,14 @@ export function evalCode(code, ret = () => {}) {
   } catch {}
 
   try {
-    eval(code);
+    eval(
+      code +
+        // Allows user code to show up in the devtools debugger as "user-code.js"
+        "\n//# sourceURL=user-code.js",
+    );
     return ret();
   } catch (e) {
-    return ret(`Error: ${e.message}`);
+    return ret(e);
   }
 }
 export const evalDebounced = debounce(evalCode, 500);

test/sheet-and-formula.test.js

@@ -193,7 +193,7 @@ test("Complex logical expressions in formulas", async () => {
 
 test("Evaluating bad code", () => {
   evalCode();
-  expect(evalCode(`asdf(`, (x) => x)).toBeTypeOf("string");
+  expect(evalCode(`asdf(`, (x) => x)).toBeInstanceOf(Error);
 });
 
 test("Miscellaneous standard library formula functions", async () => {