junit: Include output in JUnit report for skipped and failed benchmarks

jstemmer · jstemmer · commit d05abd413078 · 2022-06-13T00:34:20.000+01:00
diff --git a/junit/junit.go b/junit/junit.go
@@ -241,10 +241,12 @@ func createTestcaseForBenchmark(pkgName string, bm gtr.Benchmark) Testcase {
 	if bm.Result == gtr.Fail {
 		tc.Failure = &Result{
 			Message: "Failed",
+			Data:    formatOutput(bm.Output, 0),
 		}
 	} else if bm.Result == gtr.Skip {
 		tc.Skipped = &Result{
 			Message: "Skipped",
+			Data:    formatOutput(bm.Output, 0),
 		}
 	} else if len(bm.Output) > 0 {
 		tc.SystemOut = &Output{Data: formatOutput(bm.Output, 0)}
diff --git a/testdata/036-report.xml b/testdata/036-report.xml
@@ -5,13 +5,13 @@
 			<property name="go.version" value="1.0"></property>
 		</properties>
 		<testcase name="BenchmarkError" classname="package/name/benchfail" time="0.000">
-			<failure message="Failed"></failure>
+			<failure message="Failed"><![CDATA[    bench_test.go:6: error message]]></failure>
 		</testcase>
 		<testcase name="BenchmarkFatal" classname="package/name/benchfail" time="0.000">
-			<failure message="Failed"></failure>
+			<failure message="Failed"><![CDATA[    bench_test.go:10: fatal message]]></failure>
 		</testcase>
 		<testcase name="BenchmarkSkip" classname="package/name/benchfail" time="0.000">
-			<skipped message="Skipped"></skipped>
+			<skipped message="Skipped"><![CDATA[    bench_test.go:14: skip message]]></skipped>
 		</testcase>
 		<testcase name="Failure" classname="package/name/benchfail" time="0.000">
 			<error message="Runtime error"><![CDATA[goos: linux
diff --git a/testdata/110-report.xml b/testdata/110-report.xml
@@ -5,13 +5,13 @@
 			<property name="go.version" value="1.0"></property>
 		</properties>
 		<testcase name="BenchmarkError" classname="package/name/benchfail" time="0.000">
-			<failure message="Failed"></failure>
+			<failure message="Failed"><![CDATA[    bench_test.go:6: error message]]></failure>
 		</testcase>
 		<testcase name="BenchmarkFatal" classname="package/name/benchfail" time="0.000">
-			<failure message="Failed"></failure>
+			<failure message="Failed"><![CDATA[    bench_test.go:10: fatal message]]></failure>
 		</testcase>
 		<testcase name="BenchmarkSkip" classname="package/name/benchfail" time="0.000">
-			<skipped message="Skipped"></skipped>
+			<skipped message="Skipped"><![CDATA[    bench_test.go:14: skip message]]></skipped>
 		</testcase>
 		<testcase name="Failure" classname="package/name/benchfail" time="0.000">
 			<error message="Runtime error"><![CDATA[goos: linux

Original file line number	Diff line number	Diff line change
`@@ -241,10 +241,12 @@ func createTestcaseForBenchmark(pkgName string, bm gtr.Benchmark) Testcase {`
`241`	`241`	`if bm.Result == gtr.Fail {`
`242`	`242`	`tc.Failure = &Result{`
`243`	`243`	`Message: "Failed",`
	`244`	`+ Data: formatOutput(bm.Output, 0),`
`244`	`245`	`}`
`245`	`246`	`} else if bm.Result == gtr.Skip {`
`246`	`247`	`tc.Skipped = &Result{`
`247`	`248`	`Message: "Skipped",`
	`249`	`+ Data: formatOutput(bm.Output, 0),`
`248`	`250`	`}`
`249`	`251`	`} else if len(bm.Output) > 0 {`
`250`	`252`	`tc.SystemOut = &Output{Data: formatOutput(bm.Output, 0)}`