parser/gotest: Do not ignore failures in a test summary

The ReportBuilder ignores summary results if we never collected any
events for that package. While under normal circumstances we wouldn't
expect this to happen (unless some output was lost or due to a bug in
go-junit-report), we should at the very least make sure that failed
results are not ignored.

Refs #145

Author: jstemmer

parser/gotest/report_builder.go

@@ -164,7 +164,16 @@ func (b *reportBuilder) CreatePackage(packageName, newPackageName, result string
 	delete(b.packageBuilders, packageName)
 	pb.output.SetActiveID(0)
 
+	// If the packageBuilder is empty, we never received any events for this
+	// package so there's no need to continue.
 	if pb.IsEmpty() {
+		// However, we should at least report an error if the result says we
+		// failed.
+		if parseResult(result) == gtr.Fail {
+			pkg.RunError = gtr.Error{
+				Name: newPackageName,
+			}
+		}
 		return pkg
 	}
 

parser/gotest/report_builder_test.go

@@ -349,3 +349,31 @@ func TestGroupBenchmarksByName(t *testing.T) {
 		})
 	}
 }
+
+func TestReportFailedSummary(t *testing.T) {
+	events := []Event{
+		{Type: "summary", Result: "FAIL", Name: "package/name", Duration: 1 * time.Millisecond},
+	}
+	want := gtr.Report{
+		Packages: []gtr.Package{
+			{
+				Name:      "package/name",
+				Duration:  1 * time.Millisecond,
+				Timestamp: testTimestamp,
+				RunError: gtr.Error{
+					Name: "package/name",
+				},
+			},
+		},
+	}
+
+	rb := newReportBuilder()
+	rb.timestampFunc = testTimestampFunc
+	for _, ev := range events {
+		rb.ProcessEvent(ev)
+	}
+	got := rb.Build()
+	if diff := cmp.Diff(want, got); diff != "" {
+		t.Errorf("Incorrect report created, diff (-want, +got):\n%v\n", diff)
+	}
+}