go-junit-report_test should fail if no files found

greg-dennis · web-flow · commit 39473dc54e88 · 2022-08-19T10:55:25.000-04:00
Today, if the testdata directory isn't present, this test trivially passes. This makes it fail when no files are found.
diff --git a/internal/gojunitreport/go-junit-report_test.go b/internal/gojunitreport/go-junit-report_test.go
@@ -33,6 +33,9 @@ func TestRun(t *testing.T) {
 	if err != nil {
 		t.Fatalf("error finding files in testdata: %v", err)
 	}
+	if len(files) == 0 {
+		t.Fatalf("no files found in %s", testDataDir)
+	}
 
 	for _, file := range files {
 		if !matchRegex.MatchString(file) {

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,9 @@ func TestRun(t *testing.T) {`
`33`	`33`	`if err != nil {`
`34`	`34`	`t.Fatalf("error finding files in testdata: %v", err)`
`35`	`35`	`}`
	`36`	`+ if len(files) == 0 {`
	`37`	`+ t.Fatalf("no files found in %s", testDataDir)`
	`38`	`+ }`
`36`	`39`
`37`	`40`	`for _, file := range files {`
`38`	`41`	`if !matchRegex.MatchString(file) {`