Skip to content

Commit 8ba1c90

Browse files
committed
Update unevaluted with dynamic ref to be more likely to catch errors
1 parent 2834c63 commit 8ba1c90

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

tests/draft2019-09/unevaluatedItems.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -504,8 +504,9 @@
504504
"items": [
505505
{ "type": "number" },
506506
{
507-
"$recursiveRef": "#",
508-
"unevaluatedItems": false
507+
"$comment": "unevaluatedItems comes first so it's more likely to catch bugs with implementations that are sensitive to keyword ordering",
508+
"unevaluatedItems": false,
509+
"$recursiveRef": "#"
509510
}
510511
]
511512
}

tests/draft2019-09/unevaluatedProperties.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -737,8 +737,9 @@
737737
"properties": {
738738
"node": true,
739739
"branches": {
740-
"$recursiveRef": "#",
741-
"unevaluatedProperties": false
740+
"$comment": "unevaluatedProperties comes first so it's more likely to bugs errors with implementations that are sensitive to keyword ordering",
741+
"unevaluatedProperties": false,
742+
"$recursiveRef": "#"
742743
}
743744
},
744745
"required": ["node"]

tests/draft2020-12/unevaluatedItems.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,12 +480,13 @@
480480
"baseSchema": {
481481
"$id": "/baseSchema",
482482

483+
"$comment": "unevaluatedItems comes first so it's more likely to catch bugs with implementations that are sensitive to keyword ordering",
484+
"unevaluatedItems": false,
483485
"type": "array",
484486
"prefixItems": [
485487
{ "type": "string" }
486488
],
487489
"$dynamicRef": "#addons",
488-
"unevaluatedItems": false,
489490

490491
"$defs": {
491492
"defaultAddons": {

tests/draft2020-12/unevaluatedProperties.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -733,12 +733,13 @@
733733
"baseSchema": {
734734
"$id": "/baseSchema",
735735

736+
"$comment": "unevaluatedProperties comes first so it's more likely to catch bugs with implementations that are sensitive to keyword ordering",
737+
"unevaluatedProperties": false,
736738
"type": "object",
737739
"properties": {
738740
"foo": { "type": "string" }
739741
},
740742
"$dynamicRef": "#addons",
741-
"unevaluatedProperties": false,
742743

743744
"$defs": {
744745
"defaultAddons": {

0 commit comments

Comments
 (0)