Skip to content

Commit 02905b2

Browse files
committed
Fix a sloppy bug in the sanity checks in CI.
This was sloppy -- and was never running :/ because it was mis-indented, causing us to not actually check any schemas for validity. This is part of why for loops in tests are so bad, but we are a bit loose in this file (particularly because I've avoided adding dependencies so it's slightly easier to run for those who aren't Python developers). We should possibly refactor a bit anyhow so that an error is raised if the for loops are empty.
1 parent d21ed57 commit 02905b2

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

bin/jsonschema_suite

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,12 @@ def versions_and_validators():
9797
if not version.is_dir():
9898
continue
9999

100-
Validator = VALIDATORS.get(version.name)
101-
if Validator is None:
102-
warnings.warn(f"No schema validator for {version.name}")
103-
continue
100+
Validator = VALIDATORS.get(version.name)
101+
if Validator is None:
102+
warnings.warn(f"No schema validator for {version.name}")
103+
continue
104104

105-
yield version, Validator
105+
yield version, Validator
106106

107107

108108
class SanityTests(unittest.TestCase):

0 commit comments

Comments
 (0)