Merge pull request #1630 from json-api-dotnet/merge-master-into-openapi

Merge master into openapi

Author: bkoelman

.config/dotnet-tools.json

@@ -3,7 +3,7 @@
   "isRoot": true,
   "tools": {
     "jetbrains.resharper.globaltools": {
-      "version": "2024.2.6",
+      "version": "2024.2.7",
       "commands": [
         "jb"
       ],

src/JsonApiDotNetCore/AtomicOperations/DefaultOperationFilter.cs

@@ -7,13 +7,37 @@
 namespace JsonApiDotNetCore.AtomicOperations;
 
 /// <inheritdoc />
-internal sealed class DefaultOperationFilter : IAtomicOperationFilter
+public class DefaultOperationFilter : IAtomicOperationFilter
 {
     /// <inheritdoc />
-    public bool IsEnabled(ResourceType resourceType, WriteOperationKind writeOperation)
+    public virtual bool IsEnabled(ResourceType resourceType, WriteOperationKind writeOperation)
     {
+        ArgumentGuard.NotNull(resourceType);
+
+        // To match the behavior of non-operations controllers:
+        // If an operation is enabled on a base type, it is implicitly enabled on all derived types.
+        ResourceType currentResourceType = resourceType;
+
+        while (true)
+        {
+            JsonApiEndpoints? endpoints = GetJsonApiEndpoints(currentResourceType);
+            bool isEnabled = endpoints != null && Contains(endpoints.Value, writeOperation);
+
+            if (isEnabled || currentResourceType.BaseType == null)
+            {
+                return isEnabled;
+            }
+
+            currentResourceType = currentResourceType.BaseType;
+        }
+    }
+
+    protected virtual JsonApiEndpoints? GetJsonApiEndpoints(ResourceType resourceType)
+    {
+        ArgumentGuard.NotNull(resourceType);
+
         var resourceAttribute = resourceType.ClrType.GetCustomAttribute<ResourceAttribute>();
-        return resourceAttribute != null && Contains(resourceAttribute.GenerateControllerEndpoints, writeOperation);
+        return resourceAttribute?.GenerateControllerEndpoints;
     }
 
     private static bool Contains(JsonApiEndpoints endpoints, WriteOperationKind writeOperation)

src/JsonApiDotNetCore/Configuration/DefaultJsonApiApplicationBuilderEvents.cs

@@ -0,0 +1,20 @@
+using JsonApiDotNetCore.Serialization.JsonConverters;
+
+namespace JsonApiDotNetCore.Configuration;
+
+internal sealed class DefaultJsonApiApplicationBuilderEvents : IJsonApiApplicationBuilderEvents
+{
+    private readonly IJsonApiOptions _options;
+
+    public DefaultJsonApiApplicationBuilderEvents(IJsonApiOptions options)
+    {
+        ArgumentGuard.NotNull(options);
+
+        _options = options;
+    }
+
+    public void ResourceGraphBuilt(IResourceGraph resourceGraph)
+    {
+        _options.SerializerOptions.Converters.Add(new ResourceObjectConverter(resourceGraph));
+    }
+}

src/JsonApiDotNetCore/Configuration/IJsonApiApplicationBuilderEvents.cs

@@ -0,0 +1,6 @@
+namespace JsonApiDotNetCore.Configuration;
+
+internal interface IJsonApiApplicationBuilderEvents
+{
+    void ResourceGraphBuilt(IResourceGraph resourceGraph);
+}

src/JsonApiDotNetCore/Configuration/IJsonApiOptions.cs

@@ -176,15 +176,15 @@ public interface IJsonApiOptions
 
     /// <summary>
     /// Lists the JSON:API extensions that are turned on. Empty by default, but if your project contains a controller that derives from
-    /// <see cref="BaseJsonApiOperationsController" />, the <see cref="JsonApiExtension.AtomicOperations" /> and
-    /// <see cref="JsonApiExtension.RelaxedAtomicOperations" /> extensions are automatically added.
+    /// <see cref="BaseJsonApiOperationsController" />, the <see cref="JsonApiMediaTypeExtension.AtomicOperations" /> and
+    /// <see cref="JsonApiMediaTypeExtension.RelaxedAtomicOperations" /> extensions are automatically added.
     /// </summary>
     /// <remarks>
     /// To implement a custom JSON:API extension, add it here and override <see cref="JsonApiContentNegotiator.GetPossibleMediaTypes" /> to indicate which
     /// combinations of extensions are available, depending on the current endpoint. Use <see cref="IJsonApiRequest.Extensions" /> to obtain the active
     /// extensions when implementing extension-specific logic.
     /// </remarks>
-    IReadOnlySet<JsonApiExtension> Extensions { get; }
+    IReadOnlySet<JsonApiMediaTypeExtension> Extensions { get; }
 
     /// <summary>
     /// Enables to customize the settings that are used by the <see cref="JsonSerializer" />.

src/JsonApiDotNetCore/Configuration/JsonApiApplicationBuilder.cs

@@ -7,7 +7,6 @@
 using JsonApiDotNetCore.QueryStrings;
 using JsonApiDotNetCore.Repositories;
 using JsonApiDotNetCore.Resources;
-using JsonApiDotNetCore.Serialization.JsonConverters;
 using JsonApiDotNetCore.Serialization.Request;
 using JsonApiDotNetCore.Serialization.Request.Adapters;
 using JsonApiDotNetCore.Serialization.Response;
@@ -74,6 +73,8 @@ public void ConfigureResourceGraph(ICollection<Type> dbContextTypes, Action<Reso
         _services.TryAddSingleton(serviceProvider =>
         {
             var loggerFactory = serviceProvider.GetRequiredService<ILoggerFactory>();
+            var events = serviceProvider.GetRequiredService<IJsonApiApplicationBuilderEvents>();
+
             var resourceGraphBuilder = new ResourceGraphBuilder(_options, loggerFactory);
 
             var scanner = new ResourcesAssemblyScanner(_assemblyCache, resourceGraphBuilder);
@@ -93,8 +94,7 @@ public void ConfigureResourceGraph(ICollection<Type> dbContextTypes, Action<Reso
             configureResourceGraph?.Invoke(resourceGraphBuilder);
 
             IResourceGraph resourceGraph = resourceGraphBuilder.Build();
-
-            _options.SerializerOptions.Converters.Add(new ResourceObjectConverter(resourceGraph));
+            events.ResourceGraphBuilt(resourceGraph);
 
             return resourceGraph;
         });
@@ -169,6 +169,7 @@ public void ConfigureServiceContainer(ICollection<Type> dbContextTypes)
         _services.TryAddScoped<IQueryLayerComposer, QueryLayerComposer>();
         _services.TryAddScoped<IInverseNavigationResolver, InverseNavigationResolver>();
         _services.TryAddSingleton<IDocumentDescriptionLinkProvider, NoDocumentDescriptionLinkProvider>();
+        _services.TryAddSingleton<IJsonApiApplicationBuilderEvents, DefaultJsonApiApplicationBuilderEvents>();
     }
 
     private void AddMiddlewareLayer()

src/JsonApiDotNetCore/Configuration/JsonApiOptions.cs

@@ -12,7 +12,7 @@ namespace JsonApiDotNetCore.Configuration;
 [PublicAPI]
 public sealed class JsonApiOptions : IJsonApiOptions
 {
-    private static readonly IReadOnlySet<JsonApiExtension> EmptyExtensionSet = new HashSet<JsonApiExtension>().AsReadOnly();
+    private static readonly IReadOnlySet<JsonApiMediaTypeExtension> EmptyExtensionSet = new HashSet<JsonApiMediaTypeExtension>().AsReadOnly();
     private readonly Lazy<JsonSerializerOptions> _lazySerializerWriteOptions;
     private readonly Lazy<JsonSerializerOptions> _lazySerializerReadOptions;
 
@@ -100,7 +100,7 @@ public bool AllowClientGeneratedIds
     public IsolationLevel? TransactionIsolationLevel { get; set; }
 
     /// <inheritdoc />
-    public IReadOnlySet<JsonApiExtension> Extensions { get; set; } = EmptyExtensionSet;
+    public IReadOnlySet<JsonApiMediaTypeExtension> Extensions { get; set; } = EmptyExtensionSet;
 
     /// <inheritdoc />
     public JsonSerializerOptions SerializerOptions { get; } = new()
@@ -142,15 +142,15 @@ public JsonApiOptions()
     /// <param name="extensionsToAdd">
     /// The JSON:API extensions to add.
     /// </param>
-    public void IncludeExtensions(params JsonApiExtension[] extensionsToAdd)
+    public void IncludeExtensions(params JsonApiMediaTypeExtension[] extensionsToAdd)
     {
         ArgumentGuard.NotNull(extensionsToAdd);
 
         if (!Extensions.IsSupersetOf(extensionsToAdd))
         {
-            var extensions = new HashSet<JsonApiExtension>(Extensions);
+            var extensions = new HashSet<JsonApiMediaTypeExtension>(Extensions);
 
-            foreach (JsonApiExtension extension in extensionsToAdd)
+            foreach (JsonApiMediaTypeExtension extension in extensionsToAdd)
             {
                 extensions.Add(extension);
             }

src/JsonApiDotNetCore/Middleware/IJsonApiContentNegotiator.cs

@@ -12,5 +12,5 @@ public interface IJsonApiContentNegotiator
     /// Validates the Content-Type and Accept HTTP headers from the incoming request. Throws a <see cref="JsonApiException" /> if unsupported. Otherwise,
     /// returns the list of negotiated JSON:API extensions, which should always be a subset of <see cref="IJsonApiOptions.Extensions" />.
     /// </summary>
-    IReadOnlySet<JsonApiExtension> Negotiate();
+    IReadOnlySet<JsonApiMediaTypeExtension> Negotiate();
 }

src/JsonApiDotNetCore/Middleware/IJsonApiRequest.cs

@@ -63,7 +63,7 @@ public interface IJsonApiRequest
     /// <summary>
     /// The JSON:API extensions enabled for the current request. This is always a subset of <see cref="IJsonApiOptions.Extensions" />.
     /// </summary>
-    IReadOnlySet<JsonApiExtension> Extensions { get; }
+    IReadOnlySet<JsonApiMediaTypeExtension> Extensions { get; }
 
     /// <summary>
     /// Performs a shallow copy.

src/JsonApiDotNetCore/Middleware/JsonApiContentNegotiator.cs

@@ -36,7 +36,7 @@ public JsonApiContentNegotiator(IJsonApiOptions options, IHttpContextAccessor ht
     }
 
     /// <inheritdoc />
-    public IReadOnlySet<JsonApiExtension> Negotiate()
+    public IReadOnlySet<JsonApiMediaTypeExtension> Negotiate()
     {
         IReadOnlyList<JsonApiMediaType> possibleMediaTypes = GetPossibleMediaTypes();
 
@@ -66,7 +66,7 @@ public IReadOnlySet<JsonApiExtension> Negotiate()
         return mediaType;
     }
 
-    private IReadOnlySet<JsonApiExtension> ValidateAcceptHeader(IReadOnlyList<JsonApiMediaType> possibleMediaTypes, JsonApiMediaType? requestMediaType)
+    private IReadOnlySet<JsonApiMediaTypeExtension> ValidateAcceptHeader(IReadOnlyList<JsonApiMediaType> possibleMediaTypes, JsonApiMediaType? requestMediaType)
     {
         string[] acceptHeaderValues = HttpContext.Request.Headers.GetCommaSeparatedValues("Accept");
         JsonApiMediaType? bestMatch = null;
@@ -166,12 +166,12 @@ protected virtual IReadOnlyList<JsonApiMediaType> GetPossibleMediaTypes()
 
         if (IsOperationsEndpoint())
         {
-            if (_options.Extensions.Contains(JsonApiExtension.AtomicOperations))
+            if (_options.Extensions.Contains(JsonApiMediaTypeExtension.AtomicOperations))
             {
                 mediaTypes.Add(JsonApiMediaType.AtomicOperations);
             }
 
-            if (_options.Extensions.Contains(JsonApiExtension.RelaxedAtomicOperations))
+            if (_options.Extensions.Contains(JsonApiMediaTypeExtension.RelaxedAtomicOperations))
             {
                 mediaTypes.Add(JsonApiMediaType.RelaxedAtomicOperations);
             }