Skip to content

Commit d63ff38

Browse files
MilosMilos
authored andcommitted
Fixed tests - following item can has same age value as previsous(< was replaced by <=and vice versa)
1 parent b04ee1f commit d63ff38

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

test/JsonApiDotNetCoreExampleTests/Acceptance/TodoItemsControllerTests.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ public async Task Can_Sort_TodoItems_By_Nested_Attribute_Ascending()
231231

232232
const int numberOfItems = 10;
233233

234-
for (var i = 1; i < numberOfItems; i++)
234+
for (var i = 1; i <= numberOfItems; i++)
235235
{
236236
var todoItem = _todoItemFaker.Generate();
237237
todoItem.Ordinal = i;
@@ -241,7 +241,7 @@ public async Task Can_Sort_TodoItems_By_Nested_Attribute_Ascending()
241241
_context.SaveChanges();
242242

243243
var httpMethod = new HttpMethod("GET");
244-
var route = $"/api/v1/todo-items?include=owner&sort=owner.age";
244+
var route = $"/api/v1/todo-items?page[size]={numberOfItems}&include=owner&sort=owner.age";
245245
var request = new HttpRequestMessage(httpMethod, route);
246246

247247
// Act
@@ -256,7 +256,7 @@ public async Task Can_Sort_TodoItems_By_Nested_Attribute_Ascending()
256256
long lastAge = 0;
257257
foreach (var todoItemResult in deserializedBody)
258258
{
259-
Assert.True(todoItemResult.Owner.Age > lastAge);
259+
Assert.True(todoItemResult.Owner.Age >= lastAge);
260260
lastAge = todoItemResult.Owner.Age;
261261
}
262262
}
@@ -269,7 +269,7 @@ public async Task Can_Sort_TodoItems_By_Nested_Attribute_Descending()
269269

270270
const int numberOfItems = 10;
271271

272-
for (var i = 1; i < numberOfItems; i++)
272+
for (var i = 1; i <= numberOfItems; i++)
273273
{
274274
var todoItem = _todoItemFaker.Generate();
275275
todoItem.Ordinal = i;
@@ -279,7 +279,7 @@ public async Task Can_Sort_TodoItems_By_Nested_Attribute_Descending()
279279
_context.SaveChanges();
280280

281281
var httpMethod = new HttpMethod("GET");
282-
var route = $"/api/v1/todo-items?include=owner&sort=-owner.age";
282+
var route = $"/api/v1/todo-items?page[size]={numberOfItems}&include=owner&sort=-owner.age";
283283
var request = new HttpRequestMessage(httpMethod, route);
284284

285285
// Act
@@ -294,7 +294,7 @@ public async Task Can_Sort_TodoItems_By_Nested_Attribute_Descending()
294294
int maxAge = deserializedBody.Max(i => i.Owner.Age) + 1;
295295
foreach (var todoItemResult in deserializedBody)
296296
{
297-
Assert.True(todoItemResult.Owner.Age < maxAge);
297+
Assert.True(todoItemResult.Owner.Age <= maxAge);
298298
maxAge = todoItemResult.Owner.Age;
299299
}
300300
}

0 commit comments

Comments
 (0)