Fixed: serializer issue where tests influence each other (they fail together, but succeed individually)

Author: Bart Koelman

src/JsonApiDotNetCore/Models/Annotation/HasManyAttribute.cs

@@ -30,30 +30,5 @@ public HasManyAttribute(string publicName = null, Link relationshipLinks = Link.
         {
             InverseNavigation = inverseNavigationProperty;
         }
-
-        /// <summary>
-        /// Gets the value of the navigation property, defined by the relationshipName,
-        /// on the provided instance.
-        /// </summary>
-        public override object GetValue(object entity)
-        {
-           return entity?.GetType()
-               .GetProperty(PropertyInfo.Name)?
-                .GetValue(entity);
-        }
-
-        /// <summary>
-        /// Sets the value of the property identified by this attribute
-        /// </summary>
-        /// <param name="entity">The target object</param>
-        /// <param name="newValue">The new property value</param>
-        public override void SetValue(object entity, object newValue)
-        {
-            var propertyInfo = entity
-                .GetType()
-                .GetProperty(PropertyInfo.Name);
-
-            propertyInfo.SetValue(entity, newValue);
-        }
     }
 }

src/JsonApiDotNetCore/Models/Annotation/HasManyThroughAttribute.cs

@@ -70,15 +70,15 @@ public HasManyThroughAttribute(string publicName, string internalThroughName, Li
         }
 
         /// <summary>
-        /// Traverses the through the provided entity and returns the 
+        /// Traverses through the provided entity and returns the 
         /// value of the relationship on the other side of a join entity
         /// (e.g. Articles.ArticleTags.Tag).
         /// </summary>
         public override object GetValue(object entity)
         {
             var throughNavigationProperty = entity.GetType()
                 .GetProperties()
-                .SingleOrDefault(p => p.Name == InternalThroughName);
+                .Single(p => p.Name == InternalThroughName);
 
             var throughEntities = throughNavigationProperty.GetValue(entity);
 
@@ -88,17 +88,13 @@ public override object GetValue(object entity)
 
             // the right entities are included on the navigation/through entities. Extract and return them.
             var rightEntities = new List<IIdentifiable>();
-            foreach (var rightEntity in (IList)throughEntities)
+            foreach (var rightEntity in (IEnumerable)throughEntities)
                 rightEntities.Add((IIdentifiable)RightProperty.GetValue(rightEntity));
 
             return rightEntities.Cast(RightType);
         }
 
-        /// <summary>
-        /// Sets the value of the property identified by this attribute
-        /// </summary>
-        /// <param name="entity">The target object</param>
-        /// <param name="newValue">The new property value</param>
+        /// <inheritdoc />
         public override void SetValue(object entity, object newValue)
         {
             var propertyInfo = entity

src/JsonApiDotNetCore/Models/Annotation/HasOneAttribute.cs

@@ -37,14 +37,6 @@ public HasOneAttribute(string publicName = null, Link links = Link.NotConfigured
             InverseNavigation = inverseNavigationProperty;
         }
 
-
-        public override object GetValue(object entity)
-        {
-            return entity?.GetType()
-                .GetProperty(PropertyInfo.Name)?
-                 .GetValue(entity);
-        }
-
         private readonly string _explicitIdentifiablePropertyName;
 
         /// <summary>
@@ -54,11 +46,7 @@ public override object GetValue(object entity)
             ? JsonApiOptions.RelatedIdMapper.GetRelatedIdPropertyName(PropertyInfo.Name)
             : _explicitIdentifiablePropertyName;
 
-        /// <summary>
-        /// Sets the value of the property identified by this attribute
-        /// </summary>
-        /// <param name="entity">The target object</param>
-        /// <param name="newValue">The new property value</param>
+        /// <inheritdoc />
         public override void SetValue(object entity, object newValue)
         {
             string propertyName = PropertyInfo.Name;

src/JsonApiDotNetCore/Models/Annotation/RelationshipAttribute.cs

@@ -51,9 +51,21 @@ protected RelationshipAttribute(string publicName, Link relationshipLinks, bool
         public Link RelationshipLinks { get; }
         public bool CanInclude { get; }
 
-        public abstract void SetValue(object entity, object newValue);
+        /// <summary>
+        /// Gets the value of the resource property this attributes was declared on.
+        /// </summary>
+        public virtual object GetValue(object entity)
+        {
+            return PropertyInfo.GetValue(entity);
+        }
 
-        public abstract object GetValue(object entity);
+        /// <summary>
+        /// Sets the value of the resource property this attributes was declared on.
+        /// </summary>
+        public virtual void SetValue(object entity, object newValue)
+        {
+            PropertyInfo.SetValue(entity, newValue);
+        }
 
         public override string ToString()
         {

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/EndToEndTest.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.Linq.Expressions;
 using System.Net;
 using System.Net.Http;
@@ -63,14 +64,8 @@ protected IRequestSerializer GetSerializer<TResource>(Expression<Func<TResource,
         {
             var serializer = GetService<IRequestSerializer>();
             var graph = GetService<IResourceGraph>();
-            if (attributes != null)
-            {
-                serializer.AttributesToSerialize = graph.GetAttributes(attributes);
-            }
-            if (relationships != null)
-            {
-                serializer.RelationshipsToSerialize = graph.GetRelationships(relationships);
-            }
+            serializer.AttributesToSerialize = attributes != null ? graph.GetAttributes(attributes) : null;
+            serializer.RelationshipsToSerialize = relationships != null ? graph.GetRelationships(relationships) : null;
             return serializer;
         }
 

test/JsonApiDotNetCoreExampleTests/Acceptance/TestFixture.cs

@@ -35,15 +35,12 @@ public TestFixture()
         public HttpClient Client { get; set; }
         public AppDbContext Context { get; private set; }
 
-
         public IRequestSerializer GetSerializer<TResource>(Expression<Func<TResource, dynamic>> attributes = null, Expression<Func<TResource, dynamic>> relationships = null) where TResource : class, IIdentifiable
         {
             var serializer = GetService<IRequestSerializer>();
             var graph = GetService<IResourceGraph>();
-            if (attributes != null)
-                serializer.AttributesToSerialize = graph.GetAttributes(attributes);
-            if (relationships != null)
-                serializer.RelationshipsToSerialize = graph.GetRelationships(relationships);
+            serializer.AttributesToSerialize = attributes != null ? graph.GetAttributes(attributes) : null;
+            serializer.RelationshipsToSerialize = relationships != null ? graph.GetRelationships(relationships) : null;
             return serializer;
         }
 

test/NoEntityFrameworkTests/TestFixture.cs

@@ -1,13 +1,10 @@
 using JsonApiDotNetCore.Builders;
-using JsonApiDotNetCore.Internal.Contracts;
-using JsonApiDotNetCore.Models;
 using JsonApiDotNetCore.Serialization.Client;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.TestHost;
 using NoEntityFrameworkExample.Data;
 using NoEntityFrameworkExample.Models;
 using System;
-using System.Linq.Expressions;
 using JsonApiDotNetCore.Configuration;
 using Microsoft.Extensions.Logging.Abstractions;
 using NoEntityFrameworkExample;
@@ -28,17 +25,6 @@ public TestFixture()
             _services = Server.Host.Services;
         }
 
-        public IRequestSerializer GetSerializer<TResource>(Expression<Func<TResource, dynamic>> attributes = null, Expression<Func<TResource, dynamic>> relationships = null) where TResource : class, IIdentifiable
-        {
-            var serializer = GetService<IRequestSerializer>();
-            var graph = GetService<IResourceGraph>();
-            if (attributes != null)
-                serializer.AttributesToSerialize = graph.GetAttributes(attributes);
-            if (relationships != null)
-                serializer.RelationshipsToSerialize = graph.GetRelationships(relationships);
-            return serializer;
-        }
-
         public IResponseDeserializer GetDeserializer()
         {
             var options = GetService<IJsonApiOptions>();