Tweaks in error logging

Author: Bart Koelman

src/JsonApiDotNetCore/Exceptions/JsonApiException.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Net;
 using JsonApiDotNetCore.Models.JsonApiDocuments;
+using Newtonsoft.Json;
 
 namespace JsonApiDotNetCore.Exceptions
 {
@@ -22,5 +23,7 @@ public JsonApiException(HttpStatusCode status, string message)
                 Title = message
             };
         }
+
+        public override string Message => "Error = " + JsonConvert.SerializeObject(Error, Formatting.Indented);
     }
 }

src/JsonApiDotNetCore/Middleware/DefaultExceptionHandler.cs

@@ -1,8 +1,8 @@
 using System;
+using System.Diagnostics;
 using System.Net;
 using JsonApiDotNetCore.Configuration;
 using JsonApiDotNetCore.Exceptions;
-using JsonApiDotNetCore.Internal;
 using JsonApiDotNetCore.Models.JsonApiDocuments;
 using Microsoft.Extensions.Logging;
 
@@ -30,7 +30,8 @@ private void LogException(Exception exception)
         {
             var level = GetLogLevel(exception);
 
-            _logger.Log(level, exception, exception.Message);
+            Exception demystified = exception.Demystify();
+            _logger.Log(level, demystified, $"Intercepted {demystified.GetType().Name}: {demystified.Message}");
         }
 
         protected virtual LogLevel GetLogLevel(Exception exception)

test/JsonApiDotNetCoreExampleTests/Acceptance/Extensibility/CustomErrorHandlingTests.cs

@@ -31,7 +31,7 @@ public void When_using_custom_exception_handler_it_must_create_error_document_an
 
             Assert.Single(loggerFactory.Logger.Messages);
             Assert.Equal(LogLevel.Warning, loggerFactory.Logger.Messages[0].LogLevel);
-            Assert.Equal("Access is denied.", loggerFactory.Logger.Messages[0].Text);
+            Assert.Contains("Access is denied.", loggerFactory.Logger.Messages[0].Text);
         }
 
         public class CustomExceptionHandler : DefaultExceptionHandler