fix: added backward compatability relationship attr equality check

maurei · maurei · commit 5cd07d52118f · 2019-06-06T19:06:46.000+02:00
diff --git a/src/JsonApiDotNetCore/Models/RelationshipAttribute.cs b/src/JsonApiDotNetCore/Models/RelationshipAttribute.cs
@@ -100,7 +100,12 @@ public override bool Equals(object obj)
                 return false;
             }
             bool equalRelationshipName = PublicRelationshipName.Equals(attr.PublicRelationshipName);
-            bool equalPrincipalType = PrincipalType.Equals(attr.PrincipalType);
+
+            bool equalPrincipalType = true;
+            if (PrincipalType != null)
+            {
+                equalPrincipalType = PrincipalType.Equals(attr.PrincipalType);
+            }
             return IsHasMany == attr.IsHasMany && equalRelationshipName && equalPrincipalType;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,12 @@ public override bool Equals(object obj)`
`100`	`100`	`return false;`
`101`	`101`	`}`
`102`	`102`	`bool equalRelationshipName = PublicRelationshipName.Equals(attr.PublicRelationshipName);`
`103`		`- bool equalPrincipalType = PrincipalType.Equals(attr.PrincipalType);`
	`103`	`+`
	`104`	`+ bool equalPrincipalType = true;`
	`105`	`+ if (PrincipalType != null)`
	`106`	`+ {`
	`107`	`+ equalPrincipalType = PrincipalType.Equals(attr.PrincipalType);`
	`108`	`+ }`
`104`	`109`	`return IsHasMany == attr.IsHasMany && equalRelationshipName && equalPrincipalType;`
`105`	`110`	`}`
`106`	`111`