Fixed: re-fetch entity after CREATE without relationships

Author: Bart Koelman

src/JsonApiDotNetCore/Data/DefaultResourceRepository.cs

@@ -94,7 +94,7 @@ public virtual IQueryable<TResource> Sort(IQueryable<TResource> entities, SortQu
         }
 
         /// <inheritdoc />
-        public virtual async Task<TResource> CreateAsync(TResource entity)
+        public virtual async Task CreateAsync(TResource entity)
         {
             _logger.LogTrace($"Entering {nameof(CreateAsync)}({(entity == null ? "null" : "object")}).");
 
@@ -113,11 +113,11 @@ public virtual async Task<TResource> CreateAsync(TResource entity)
             _dbSet.Add(entity);
             await _context.SaveChangesAsync();
 
+            FlushFromCache(entity);
+
             // this ensures relationships get reloaded from the database if they have
             // been requested. See https://github.com/json-api-dotnet/JsonApiDotNetCore/issues/343
             DetachRelationships(entity);
-
-            return entity;
         }
 
         /// <summary>

src/JsonApiDotNetCore/Data/IResourceWriteRepository.cs

@@ -12,7 +12,7 @@ public interface IResourceWriteRepository<TResource>
     public interface IResourceWriteRepository<TResource, in TId>
         where TResource : class, IIdentifiable<TId>
     {
-        Task<TResource> CreateAsync(TResource entity);
+        Task CreateAsync(TResource entity);
 
         Task UpdateAsync(TResource requestEntity, TResource databaseEntity);
 

src/JsonApiDotNetCore/Services/DefaultResourceService.cs

@@ -62,13 +62,12 @@ public DefaultResourceService(
 
         public virtual async Task<TResource> CreateAsync(TResource entity)
         {
-            _logger.LogTrace($"Entering {nameof(CreateAsync)}({(entity == null ? "null" : "object")}).");
+            _logger.LogTrace($"Entering {nameof(CreateAsync)}(object).");
 
             entity = IsNull(_hookExecutor) ? entity : _hookExecutor.BeforeCreate(AsList(entity), ResourcePipeline.Post).SingleOrDefault();
-            entity = await _repository.CreateAsync(entity);
+            await _repository.CreateAsync(entity);
 
-            if (_includeService.Get().Any())
-                entity = await GetWithRelationshipsAsync(entity.Id);
+            entity = await GetWithRelationshipsAsync(entity.Id);
 
             if (!IsNull(_hookExecutor, entity))
             {

test/JsonApiDotNetCoreExampleTests/Acceptance/TodoItemsControllerTests.cs

@@ -542,11 +542,10 @@ public async Task Can_Post_TodoItem()
             Assert.Equal(HttpStatusCode.Created, response.StatusCode);
             Assert.Equal(todoItem.Description, deserializedBody.Description);
             Assert.Equal(todoItem.CreatedDate.ToString("G"), deserializedBody.CreatedDate.ToString("G"));
-            Assert.Equal(nowOffset.ToString("yyyy-MM-ddTHH:mm:ssK"), deserializedBody.OffsetDate?.ToString("yyyy-MM-ddTHH:mm:ssK"));
+            Assert.Equal(nowOffset, deserializedBody.OffsetDate);
             Assert.Null(deserializedBody.AchievedDate);
         }
 
-
         [Fact]
         public async Task Can_Post_TodoItem_With_Different_Owner_And_Assignee()
         {