Fix IDE0200: Remove unnecessary lambda expression

Author: bkoelman

src/Examples/DapperExample/TranslationToSql/Builders/DeleteResourceStatementBuilder.cs

@@ -26,7 +26,7 @@ public DeleteNode Build(ResourceType resourceType, params object[] idValues)
 
     private WhereNode GetWhere(ColumnNode idColumn, IEnumerable<object> idValues)
     {
-        ReadOnlyCollection<ParameterNode> parameters = idValues.Select(idValue => ParameterGenerator.Create(idValue)).ToArray().AsReadOnly();
+        ReadOnlyCollection<ParameterNode> parameters = idValues.Select(ParameterGenerator.Create).ToArray().AsReadOnly();
         FilterNode filter = parameters.Count == 1 ? new ComparisonNode(ComparisonOperator.Equals, idColumn, parameters[0]) : new InNode(idColumn, parameters);
         return new WhereNode(filter);
     }

src/Examples/DapperExample/TranslationToSql/Builders/UpdateResourceStatementBuilder.cs

@@ -44,7 +44,7 @@ private ReadOnlyCollection<ColumnAssignmentNode> GetColumnAssignments(IReadOnlyD
 
     private WhereNode GetWhere(ColumnNode idColumn, IEnumerable<object> idValues)
     {
-        ReadOnlyCollection<ParameterNode> parameters = idValues.Select(idValue => ParameterGenerator.Create(idValue)).ToArray().AsReadOnly();
+        ReadOnlyCollection<ParameterNode> parameters = idValues.Select(ParameterGenerator.Create).ToArray().AsReadOnly();
         FilterNode filter = parameters.Count == 1 ? new ComparisonNode(ComparisonOperator.Equals, idColumn, parameters[0]) : new InNode(idColumn, parameters);
         return new WhereNode(filter);
     }

src/JsonApiDotNetCore/Repositories/EntityFrameworkCoreRepository.cs

@@ -486,7 +486,7 @@ private ISet<IIdentifiable> GetRightValueToStoreForAddToToMany(TResource leftRes
 
         HashSet<IIdentifiable> rightResourceIdsStored = _collectionConverter
             .ExtractResources(rightValueStored)
-            .Select(rightResource => _dbContext.GetTrackedOrAttach(rightResource))
+            .Select(_dbContext.GetTrackedOrAttach)
             .ToHashSet(IdentifiableComparer.Instance);
 
         // @formatter:wrap_before_first_method_call restore
@@ -536,7 +536,7 @@ public virtual async Task RemoveFromToManyRelationshipAsync(TResource leftResour
             IIdentifiable[] rightResourceIdsStored = _collectionConverter
                 .ExtractResources(rightValueStored)
                 .Concat(extraResourceIdsToRemove)
-                .Select(rightResource => _dbContext.GetTrackedOrAttach(rightResource))
+                .Select(_dbContext.GetTrackedOrAttach)
                 .ToArray();
 
             // @formatter:wrap_before_first_method_call restore
@@ -625,7 +625,7 @@ protected async Task UpdateRelationshipAsync(RelationshipAttribute relationship,
         }
 
         IReadOnlyCollection<IIdentifiable> rightResources = _collectionConverter.ExtractResources(rightValue);
-        IIdentifiable[] rightResourcesTracked = rightResources.Select(rightResource => _dbContext.GetTrackedOrAttach(rightResource)).ToArray();
+        IIdentifiable[] rightResourcesTracked = rightResources.Select(_dbContext.GetTrackedOrAttach).ToArray();
 
         return rightValue is IEnumerable
             ? _collectionConverter.CopyToTypedCollection(rightResourcesTracked, relationshipPropertyType)

test/DapperTests/IntegrationTests/AtomicOperations/AtomicOperationsTests.cs

@@ -421,10 +421,7 @@ public async Task Can_rollback_on_error()
 
         const string personLocalId = "new-person";
 
-        await _testContext.RunOnDatabaseAsync(async dbContext =>
-        {
-            await _testContext.ClearAllTablesAsync(dbContext);
-        });
+        await _testContext.RunOnDatabaseAsync(_testContext.ClearAllTablesAsync);
 
         var requestBody = new
         {

test/JsonApiDotNetCoreTests/IntegrationTests/CompositeKeys/CarCompositeKeyAwareRepository.cs

@@ -39,8 +39,7 @@ private void RecursiveRewriteFilterInLayer(QueryLayer queryLayer)
 
         if (queryLayer.Selection is { IsEmpty: false })
         {
-            foreach (QueryLayer? nextLayer in queryLayer.Selection.GetResourceTypes()
-                .Select(resourceType => queryLayer.Selection.GetOrCreateSelectors(resourceType))
+            foreach (QueryLayer? nextLayer in queryLayer.Selection.GetResourceTypes().Select(queryLayer.Selection.GetOrCreateSelectors)
                 .SelectMany(selectors => selectors.Select(selector => selector.Value).Where(layer => layer != null)))
             {
                 RecursiveRewriteFilterInLayer(nextLayer!);