Fixed: stackTrace:null in output when options.IncludeExceptionStackTraceInErrors = false

Bart Koelman · Bart Koelman · commit 2d5bc9920333 · 2020-04-13T17:22:06.000+02:00
diff --git a/src/JsonApiDotNetCore/Models/JsonApiDocuments/ErrorMeta.cs b/src/JsonApiDotNetCore/Models/JsonApiDocuments/ErrorMeta.cs
@@ -15,8 +15,15 @@ public sealed class ErrorMeta
 
         public void IncludeExceptionStackTrace(Exception exception)
         {
-            Data["StackTrace"] = exception?.Demystify().ToString()
-                .Split(new[] {"\n"}, int.MaxValue, StringSplitOptions.RemoveEmptyEntries);
+            if (exception == null)
+            {
+                Data.Remove("StackTrace");
+            }
+            else
+            {
+                Data["StackTrace"] = exception.Demystify().ToString()
+                    .Split(new[] { "\n" }, int.MaxValue, StringSplitOptions.RemoveEmptyEntries);
+            }
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,15 @@ public sealed class ErrorMeta`
`15`	`15`
`16`	`16`	`public void IncludeExceptionStackTrace(Exception exception)`
`17`	`17`	`{`
`18`		`- Data["StackTrace"] = exception?.Demystify().ToString()`
`19`		`- .Split(new[] {"\n"}, int.MaxValue, StringSplitOptions.RemoveEmptyEntries);`
	`18`	`+ if (exception == null)`
	`19`	`+ {`
	`20`	`+ Data.Remove("StackTrace");`
	`21`	`+ }`
	`22`	`+ else`
	`23`	`+ {`
	`24`	`+ Data["StackTrace"] = exception.Demystify().ToString()`
	`25`	`+ .Split(new[] { "\n" }, int.MaxValue, StringSplitOptions.RemoveEmptyEntries);`
	`26`	`+ }`
`20`	`27`	`}`
`21`	`28`	`}`
`22`	`29`	`}`