Updated tests no never use the real clock

Author: Bart Koelman

src/Examples/JsonApiDotNetCoreExample/Startups/KebabCaseStartup.cs

@@ -8,7 +8,7 @@ namespace JsonApiDotNetCoreExample
     /// This should be in JsonApiDotNetCoreExampleTests project but changes in .net core 3.0
     /// do no longer allow that. See https://github.com/aspnet/AspNetCore/issues/15373.
     /// </summary>
-    public sealed class KebabCaseStartup : Startup
+    public sealed class KebabCaseStartup : TestStartup
     {
         public KebabCaseStartup(IWebHostEnvironment env) : base(env)
         {

src/Examples/JsonApiDotNetCoreExample/Startups/MetaStartup.cs

@@ -9,7 +9,7 @@ namespace JsonApiDotNetCoreExample
     /// This should be in JsonApiDotNetCoreExampleTests project but changes in .net core 3.0
     /// do no longer allow that. See https://github.com/aspnet/AspNetCore/issues/15373.
     /// </summary>
-    public sealed class MetaStartup : Startup
+    public sealed class MetaStartup : TestStartup
     {
         public MetaStartup(IWebHostEnvironment env) : base(env) { }
 

src/Examples/JsonApiDotNetCoreExample/Startups/NoDefaultPageSizeStartup.cs

@@ -7,7 +7,7 @@ namespace JsonApiDotNetCoreExample
     /// This should be in JsonApiDotNetCoreExampleTests project but changes in .net core 3.0
     /// do no longer allow that. See https://github.com/aspnet/AspNetCore/issues/15373.
     /// </summary>
-    public sealed class NoDefaultPageSizeStartup : Startup
+    public sealed class NoDefaultPageSizeStartup : TestStartup
     {
         public NoDefaultPageSizeStartup(IWebHostEnvironment env) : base(env) { }
 

src/Examples/JsonApiDotNetCoreExample/Startups/Startup.cs

@@ -30,7 +30,8 @@ public Startup(IWebHostEnvironment env)
 
         public virtual void ConfigureServices(IServiceCollection services)
         {
-            services.AddSingleton<ISystemClock, SystemClock>();
+            ConfigureClock(services);
+
             services.AddScoped<SkipCacheQueryParameterService>();
             services.AddScoped<IQueryParameterService>(sp => sp.GetService<SkipCacheQueryParameterService>());
 
@@ -47,6 +48,11 @@ public virtual void ConfigureServices(IServiceCollection services)
             services.AddClientSerialization();
         }
 
+        protected virtual void ConfigureClock(IServiceCollection services)
+        {
+            services.AddSingleton<ISystemClock, SystemClock>();
+        }
+
         protected virtual void ConfigureJsonApiOptions(JsonApiOptions options)
         {
             options.IncludeExceptionStackTraceInErrors = true;

src/Examples/JsonApiDotNetCoreExample/Startups/TestStartup.cs

@@ -0,0 +1,44 @@
+using System;
+using Microsoft.AspNetCore.Authentication;
+using Microsoft.AspNetCore.Hosting;
+using Microsoft.Extensions.DependencyInjection;
+
+namespace JsonApiDotNetCoreExample
+{
+    public class TestStartup : Startup
+    {
+        public TestStartup(IWebHostEnvironment env) : base(env)
+        {
+        }
+
+        protected override void ConfigureClock(IServiceCollection services)
+        {
+            services.AddSingleton<ISystemClock, AlwaysChangingSystemClock>();
+        }
+
+        private class AlwaysChangingSystemClock : ISystemClock
+        {
+            private DateTimeOffset _utcNow;
+
+            public DateTimeOffset UtcNow
+            {
+                get
+                {
+                    var utcNow = _utcNow;
+                    _utcNow = _utcNow.AddSeconds(1);
+                    return utcNow;
+                }
+            }
+
+            public AlwaysChangingSystemClock()
+                : this(new DateTimeOffset(new DateTime(2000, 1, 1)))
+            {
+            }
+
+            public AlwaysChangingSystemClock(DateTimeOffset utcNow)
+            {
+                _utcNow = utcNow;
+            }
+        }
+    }
+}

test/JsonApiDotNetCoreExampleTests/Acceptance/ActionResultTests.cs

@@ -14,9 +14,9 @@ namespace JsonApiDotNetCoreExampleTests.Acceptance
     [Collection("WebHostCollection")]
     public sealed class ActionResultTests
     {
-        private readonly TestFixture<Startup> _fixture;
+        private readonly TestFixture<TestStartup> _fixture;
 
-        public ActionResultTests(TestFixture<Startup> fixture)
+        public ActionResultTests(TestFixture<TestStartup> fixture)
         {
             _fixture = fixture;
         }

test/JsonApiDotNetCoreExampleTests/Acceptance/Extensibility/CustomControllerTests.cs

@@ -21,11 +21,11 @@ namespace JsonApiDotNetCoreExampleTests.Acceptance.Extensibility
     [Collection("WebHostCollection")]
     public sealed class CustomControllerTests
     {
-        private readonly TestFixture<Startup> _fixture;
+        private readonly TestFixture<TestStartup> _fixture;
         private readonly Faker<TodoItem> _todoItemFaker;
         private readonly Faker<Person> _personFaker;
 
-        public CustomControllerTests(TestFixture<Startup> fixture)
+        public CustomControllerTests(TestFixture<TestStartup> fixture)
         {
             _fixture = fixture;
             _todoItemFaker = new Faker<TodoItem>()
@@ -41,7 +41,7 @@ public async Task NonJsonApiControllers_DoNotUse_Dasherized_Routes()
         {
             // Arrange
             var builder = new WebHostBuilder()
-                .UseStartup<Startup>();
+                .UseStartup<TestStartup>();
             var httpMethod = new HttpMethod("GET");
             var route = "testValues";
 
@@ -61,7 +61,7 @@ public async Task CustomRouteControllers_Uses_Dasherized_Collection_Route()
         {
             // Arrange
             var builder = new WebHostBuilder()
-                .UseStartup<Startup>();
+                .UseStartup<TestStartup>();
             var httpMethod = new HttpMethod("GET");
             var route = "/custom/route/todoItems";
 
@@ -88,7 +88,7 @@ public async Task CustomRouteControllers_Uses_Dasherized_Item_Route()
             await context.SaveChangesAsync();
 
             var builder = new WebHostBuilder()
-                .UseStartup<Startup>();
+                .UseStartup<TestStartup>();
             var httpMethod = new HttpMethod("GET");
             var route = $"/custom/route/todoItems/{todoItem.Id}";
 
@@ -114,7 +114,7 @@ public async Task CustomRouteControllers_Creates_Proper_Relationship_Links()
             context.TodoItems.Add(todoItem);
             await context.SaveChangesAsync();
 
-            var builder = new WebHostBuilder().UseStartup<Startup>();
+            var builder = new WebHostBuilder().UseStartup<TestStartup>();
             var httpMethod = new HttpMethod("GET");
             var route = $"/custom/route/todoItems/{todoItem.Id}";
 
@@ -139,7 +139,7 @@ public async Task CustomRouteControllers_Creates_Proper_Relationship_Links()
         public async Task ApiController_attribute_transforms_NotFound_action_result_without_arguments_into_ProblemDetails()
         {
             // Arrange
-            var builder = new WebHostBuilder().UseStartup<Startup>();
+            var builder = new WebHostBuilder().UseStartup<TestStartup>();
             var route = "/custom/route/todoItems/99999999";
 
             var requestBody = new

test/JsonApiDotNetCoreExampleTests/Acceptance/Extensibility/IgnoreDefaultValuesTests.cs

@@ -21,7 +21,7 @@ public sealed class IgnoreDefaultValuesTests : IAsyncLifetime
         private readonly AppDbContext _dbContext;
         private readonly TodoItem _todoItem;
 
-        public IgnoreDefaultValuesTests(TestFixture<Startup> fixture)
+        public IgnoreDefaultValuesTests(TestFixture<TestStartup> fixture)
         {
             _dbContext = fixture.GetService<AppDbContext>();
             var todoItem = new TodoItem
@@ -90,7 +90,7 @@ public Task DisposeAsync()
         [InlineData(DefaultValueHandling.Include, true, "", null)]
         public async Task CheckBehaviorCombination(DefaultValueHandling? defaultValue, bool? allowQueryStringOverride, string queryStringValue, DefaultValueHandling? expected)
         {
-            var builder = new WebHostBuilder().UseStartup<Startup>();
+            var builder = new WebHostBuilder().UseStartup<TestStartup>();
             var server = new TestServer(builder);
             var services = server.Host.Services;
             var client = server.CreateClient();

test/JsonApiDotNetCoreExampleTests/Acceptance/Extensibility/IgnoreNullValuesTests.cs

@@ -21,7 +21,7 @@ public sealed class IgnoreNullValuesTests : IAsyncLifetime
         private readonly AppDbContext _dbContext;
         private readonly TodoItem _todoItem;
 
-        public IgnoreNullValuesTests(TestFixture<Startup> fixture)
+        public IgnoreNullValuesTests(TestFixture<TestStartup> fixture)
         {
             _dbContext = fixture.GetService<AppDbContext>();
             var todoItem = new TodoItem
@@ -93,7 +93,7 @@ public Task DisposeAsync()
         [InlineData(NullValueHandling.Include, true, "", null)]
         public async Task CheckBehaviorCombination(NullValueHandling? defaultValue, bool? allowQueryStringOverride, string queryStringValue, NullValueHandling? expected)
         {
-            var builder = new WebHostBuilder().UseStartup<Startup>();
+            var builder = new WebHostBuilder().UseStartup<TestStartup>();
             var server = new TestServer(builder);
             var services = server.Host.Services;
             var client = server.CreateClient();

test/JsonApiDotNetCoreExampleTests/Acceptance/Extensibility/RequestMetaTests.cs

@@ -14,9 +14,9 @@ namespace JsonApiDotNetCoreExampleTests.Acceptance.Extensibility
     [Collection("WebHostCollection")]
     public sealed class RequestMetaTests
     {
-        private readonly TestFixture<Startup> _fixture;
+        private readonly TestFixture<TestStartup> _fixture;
 
-        public RequestMetaTests(TestFixture<Startup> fixture)
+        public RequestMetaTests(TestFixture<TestStartup> fixture)
         {
             _fixture = fixture;
         }