fix(devtool): allow false as devtool value (#128)

Author: le0nik

src/properties/devtool/index.js

@@ -22,6 +22,7 @@ const DEVTOOL_REGEX = new RegExp(
   `(${options.join('$|')})` // one of the options
 )
 
-export default Joi
-  .string()
-  .regex(DEVTOOL_REGEX)
+export default [
+  Joi.string().regex(DEVTOOL_REGEX),
+  Joi.any().valid(false),
+]

src/properties/devtool/index.test.js

@@ -11,13 +11,16 @@ const validModuleConfigs = [
   { input: 'eval-source-map' },
   { input: 'cheap-source-map' },
   { input: 'hidden-source-map' },
+  { input: false },
 ]
 
 const invalidModuleConfigs = [
   { input: 'foo', error: { } },
   { input: 'eval-source-map-foo', error: { } },
   { input: 'foo-cheap-source-map', error: { } },
   { input: '#@eval-foo', error: { } },
+  { input: 'false', error: { } },
+  { input: true, error: { } },
 ]
 
 describe('devtool', () => {

test/utils/allValid.js

@@ -7,14 +7,15 @@ import validate from '../../src'
  */
 export default (configs, schema) => {
   configs.forEach((input) => {
-    const { input: validConfig, schema: schemaOverride } = input
-    if (!validConfig) {
+    if (!Object.prototype.hasOwnProperty.call(input, 'input')) {
       throw new Error(
         'Please supply the valid config object like `{ input: <valid-config-object> }`.' +
         `You passed ${JSON.stringify(input)}`
       )
     }
 
+    const { input: validConfig, schema: schemaOverride } = input
+
     it(`: ${chalk.gray(util.inspect(validConfig, false, null))} should be valid`, () => {
       const result = validate(validConfig, {
         schema: schemaOverride || schema,