test: improve testing utils (#96)

* test: improve testing utils

* test: remove comments

Author: jonathanglasmeyer

src/properties/context/index.test.js

@@ -2,16 +2,11 @@ import schema from './index'
 import { allValid, allInvalid } from '../../../test/utils'
 
 const validModuleConfigs = [
-  // #0
   { input: 'exists' }, // Absolute
 ]
 
 const invalidModuleConfigs = [
-  // #0
-  // Relative
-  { input: './entry.js', error: { type: 'path.absolute' } },
-
-  // #1
+  { input: './entry.js', error: { type: 'path.absolute' } }, // Relative
   { input: 1, error: { message: '"value" must be a string' } },
 ]
 

src/properties/devServer/index.test.js

@@ -3,94 +3,50 @@ import { allValid, allInvalid } from '../../../test/utils'
 import { urlPart } from '../../types'
 
 const validModuleConfigs = [
-  // #0
   { input: { lazy: true } },
-  // #1
   { input: { inline: true } },
-  // #2
   { input: { stdin: true } },
-  // #2
   { input: { open: true } },
-  // #4
   { input: { info: true } },
-  // #5
   { input: { quiet: true } },
-  // #6
   { input: { https: true } },
-  // #7
   { input: { key: '/path/to/key' } },
-  // #8
   { input: { cert: 'path/to/cert' } },
-  // #9
   { input: { cacert: 'path/to/cacert' } },
-  // #10
   { input: { contentBase: '/content/base' } },
-  // #11
   { input: { contentBase: { target: '/content/base/' } } },
-  // #12
   { input: { contentBase: ['/content/base/'] } },
-  // #13
   { input: { historyApiFallback: true } },
-  // #14
   { input: { historyApiFallback: { index: '/foo-app/' } } },
-  // #15
   { input: { compress: true } },
-  // #16
   { input: { port: 3000 } },
-  // #17
   { input: { public: 'localhost' } },
-  // #18
   { input: { host: '0.0.0.0' } },
-  // #19
   { input: { publicPath: '/public/path/' } },
-  // #20
   { input: { publicPath: 'public/path/' } },
-  // #21
   { input: { outputPath: '/' } },
-  // #22
   { input: { filename: 'bundle.js' } },
-  // #23
   { input: { watchOptions: {} } },
-  // #24
   { input: { hot: true } },
-  // #25
   { input: { stats: {} } },
-  // #26
   { input: { stats: 'none' } },
-  // #27
   { input: { stats: 'errors-only' } },
-  // #28
   { input: { stats: 'minimal' } },
-  // #29
   { input: { stats: 'normal' } },
-  // #30
   { input: { stats: 'verbose' } },
-  // #31
   { input: { noInfo: true } },
-  // #32
   { input: { proxy: {} } },
-  // #33
-  { input: { proxy: 'http://proxy.url/' } },
-  // #34
   { input: { proxy: [] } },
-  // #35
   { input: { staticOptions: {} } },
-  // #36
   { input: { headers: {} } },
 ]
 
 const invalidModuleConfigs = [
-  // #0
   { input: { publicPath: 'public/path' }, error: { message: `"publicPath" ${urlPart.message}` } },
-  // #1
   { input: { outputPath: './output/path' }, error: { message: `"outputPath" ${urlPart.message}` } },
-  // #2
   { input: { watchOptions: true } },
-  // #3
   { input: { stats: true } },
-  // #4
   { input: { stats: 'foobar' } },
-  // #5
   { input: { proxy: true } },
 ]
 

src/properties/devtool/index.test.js

@@ -2,30 +2,19 @@ import schema from './index'
 import { allValid, allInvalid } from '../../../test/utils'
 
 const validModuleConfigs = [
-  // #0
   { input: 'eval' },
-  // #1
   { input: '#@eval' },
-  // #2
   { input: '#cheap-module-eval-source-map' },
-  // #3
   { input: 'hidden-source-map' },
-  // #4
   { input: 'inline-source-map' },
-  // #5
   { input: 'eval-source-map' },
-  // #6
   { input: 'cheap-source-map' },
 ]
 
 const invalidModuleConfigs = [
-  // #0
   { input: 'foo', error: { } },
-  // #1
   { input: 'eval-source-map-foo', error: { } },
-  // #2
   { input: 'foo-cheap-source-map', error: { } },
-  // #3
   { input: '#@eval-foo', error: { } },
 ]
 

src/properties/entry/index.test.js

@@ -2,27 +2,15 @@ import schema from './index'
 import { allValid, allInvalid } from '../../../test/utils'
 
 const validModuleConfigs = [
-  // #0
   { input: './entry.js' },
-
-  // #1
   { input: ['./entry.js'] },
-
-  // #2
   { input: { foo: './entry.js', bar: ['./bar.js'] } },
 ]
 
 const invalidModuleConfigs = [
-  // #0
   { input: 1, error: { message: '"value" must be a string' } },
-
-  // #1
   { input: [1], error: { message: '"0" must be a string' } },
-
-  // #2
   { input: [1, 'foo'], error: { message: '"0" must be a string' } },
-
-  // #3
   { input: { foo: 1, bar: ['./bar.js'] }, error: { message: '"value" must be a string' } },
 ]
 

src/properties/externals/index.test.js

@@ -2,23 +2,17 @@ import schema, { EXTERNALS_MESSAGE } from './index'
 import { allValid, allInvalid } from '../../../test/utils'
 
 const validModuleConfigs = [
-  // #0
   { input: 'dependency' },
-
-  // #1
   { input: ['dependency'] },
-
-  // #2 ( from https://webpack.github.io/docs/configuration.html#externals )
   {
+    // from https://webpack.github.io/docs/configuration.html#externals )
     input: {
       a: false,
       b: true,
       './c': 'c',
       './d': 'var d',
     },
   },
-
-  // #3 ( from real life )
   {
     input: [
       {
@@ -32,16 +26,11 @@ const validModuleConfigs = [
       },
     ],
   },
-
-  // #4
   { input: /dependency/ },
-
-  // #5
   { input: (a, b, c) => { } }, // eslint-disable-line
 ]
 
 const invalidModuleConfigs = [
-  // #0
   {
     input: {
       a: ['foo'],
@@ -51,8 +40,6 @@ const invalidModuleConfigs = [
     },
     error: { message: `"value" ${EXTERNALS_MESSAGE}` },
   },
-
-  // #1
   {
     input: [{
       a: ['foo'],
@@ -62,16 +49,12 @@ const invalidModuleConfigs = [
     }],
     error: { message: `"value" ${EXTERNALS_MESSAGE}` },
   },
-
-  // #2
   {
     input: 1,
     error: { message: `"value" ${EXTERNALS_MESSAGE}` },
   },
-
-  // #3
-  // Only 3-arity allowed
   {
+    // Only 3-arity allowed
     input: (a, b, c, d) => { }, // eslint-disable-line
     error: { message: `"value" ${EXTERNALS_MESSAGE}` },
   },

src/properties/module/index.test.js

@@ -2,39 +2,34 @@ import moduleSchema, { CONDITION_MESSAGE, LOADERS_QUERY_MESSAGE } from './index'
 import { allValid, allInvalid } from '../../../test/utils'
 
 const validModuleConfigs = [
-  // #0
   {
     input: {
       loaders: [
         { test: 'foo', include: /src/, loader: 'babel' },
       ],
     },
   },
-  // #1
   {
     input: {
       loaders: [
         { test: /\.less$/, loader: 'style-loader!css-loader!autoprefixer-loader!less-loader' },
       ],
     },
   },
-  // #2
   {
     input: {
       loaders: [
         { test: /\.(?:eot|ttf|woff2?)$/, loaders: ['file-loader'] },
       ],
     },
   },
-  // #3
   {
     input: {
       loaders: [
         { test: (absPath) => absPath && true, loaders: ['file-loader'] },
       ],
     },
   },
-  // #4
   {
     input: {
       loaders: [
@@ -45,7 +40,6 @@ const validModuleConfigs = [
 ]
 
 const invalidModuleConfigs = [
-  // #0
   {
     input: {
       loaders: [
@@ -54,7 +48,6 @@ const invalidModuleConfigs = [
     },
     error: { message: '"test" is required' },
   },
-  // #1
   {
     input: {
       loaders: [
@@ -63,7 +56,6 @@ const invalidModuleConfigs = [
     },
     error: { message: `"include" ${CONDITION_MESSAGE}` },
   },
-  // #2
   {
     input: {
       loaders: [
@@ -72,7 +64,6 @@ const invalidModuleConfigs = [
     },
     error: { message: '"loaders" must be an array' },
   },
-  // #3
   {
     input: {
       loaders: [
@@ -81,44 +72,38 @@ const invalidModuleConfigs = [
     },
     error: { message: '"0" must be a string', path: 'loaders.0.loaders.0' },
   },
-  // #4
   {
     input: {
       loaders: [{ test: /\.(?:eot|ttf|woff2?)$/, loader: ['file-loader'] }],
     },
     error: { message: '"loader" must be a string' },
   },
-  // #5
   {
     input: {
       loaders: [{ test: /\.(?:eot|ttf|woff2?)$/, loaders: ['file-loader'], loader: 'style' }],
     },
     error: { message: '"value" contains a conflict between exclusive peers [loaders, loader]' },
   },
-  // #6
   {
     input: {
       loaders: [{ test: (foo, bar) => `${foo}-${bar}`, loaders: ['file-loader'] }],
     },
     // Only 1-arity functions are allowed
     error: { message: `"test" ${CONDITION_MESSAGE}` },
   },
-  // #7
   {
     input: {
       loaders: [{ query: { foo: 'bar' }, loaders: ['file-loader'], test: /foo/ }],
     },
     // query can only be supplied when `loader` property is supplied
     error: { message: `"value" ${LOADERS_QUERY_MESSAGE}` },
   },
-  // #8
   {
     input: {
       loaders: [{ test: /foo/ }],
     },
     error: { message: '"value" must contain at least one of [loaders, loader]' },
   },
-  // #9
   {
     input: {
       loaders: [{ test: /foo/, loader: 'foo', query: 'query' }],

src/properties/node/index.test.js

@@ -2,33 +2,16 @@ import schema from './index'
 import { allValid, allInvalid } from '../../../test/utils'
 
 const validModuleConfigs = [
-  // #0
   { input: { console: true } },
-
-  // #1
   { input: { global: true } },
-
-  // #2
   { input: { Buffer: true } },
-
-  // #3
   { input: { process: 'mock' } },
-
-  // #4
   { input: { __filename: true } },
-
-  // #5
   { input: { __dirname: false } },
-
-  // #6
   { input: { foo: 'mock' } },
 ]
 
 const invalidModuleConfigs = [
-  // #0
-  // { input: { foo: 'mocka' }, error: { } },
-
-  // #0
   { input: [1], error: { } },
 ]