fix: support webpack multi-compiler (#119)

* fix: support webpack multi-compiler

when provided with an array of configurations, iterate array and validate each configuration
individually

fixes #117

* refactor: use ES6 module import

use import instead of require for validate module

Author: sadafie

src/bin/validate-config.js

@@ -1,5 +1,5 @@
 const path = require('path')
-const validate = require('../')
+const validate = require('../index').validateRoot
 const argv = require('yargs').argv
 
 module.exports = function validateConfig(webpackConfigFile, quiet) {

src/index.js

@@ -17,7 +17,15 @@ import sh from 'shelljs'
 
 sh.config.silent = true
 
-const makeSchema = (schemaOptions, schemaExtension) => {
+const defaultSchemaOptions = {
+  rules: {
+    'no-root-files-node-modules-nameclash': true,
+    'loader-enforce-include-or-exclude': false,
+    'loader-prefer-include': false,
+  },
+}
+
+function makeSchema(schemaOptions, schemaExtension) {
   const resolveSchema = resolveSchemaFn(schemaOptions)
   const moduleSchema = moduleSchemaFn(schemaOptions)
 
@@ -59,20 +67,10 @@ const makeSchema = (schemaOptions, schemaExtension) => {
   return schemaExtension ? schema.concat(schemaExtension) : schema
 }
 
-const defaultSchemaOptions = {
-  rules: {
-    'no-root-files-node-modules-nameclash': true,
-    'loader-enforce-include-or-exclude': false,
-    'loader-prefer-include': false,
-  },
-}
-
-// Easier consumability for require (default use case for non-transpiled webpack configs)
-module.exports = function validate(config, options = {}) {
+function validate(config, options) {
   const {
     // Don't return the config object and throw on error, but just return the validation result
     returnValidation, // bool
-    quiet, // bool
     schema: overrideSchema, // Don't take internal schema, but override with this one
     schemaExtension, // Internal schema will be `Joi.concat`-ted with this schema if supplied
     rules,
@@ -92,11 +90,36 @@ module.exports = function validate(config, options = {}) {
     process.exit(1)
   }
 
+  return config
+}
+
+// Easier consumability for require (default use case for non-transpiled webpack configs)
+function validateRoot(config, options = {}) {
+  const {
+    quiet,
+  } = options
+
+  let validationResult,
+    multiValidationResults
+
+  if (Array.isArray(config)) {
+    multiValidationResults = []
+    config.forEach((cfg) => {
+      multiValidationResults.push(
+        validate(cfg, options)
+      )
+    })
+  } else {
+    validationResult = validate(config, options)
+  }
+
   if (!quiet) {
     console.info(chalk.green('[webpack-validator] Config is valid.'))
   }
 
-  return config
+  return validationResult || multiValidationResults
 }
 
-module.exports.Joi = Joi
+exports.validate = validate
+exports.validateRoot = validateRoot
+exports.Joi = Joi

src/index.test.js

@@ -1,7 +1,9 @@
 import sinon from 'sinon'
 import configs from '../test/passing-configs'
 import failingConfigs from '../test/failing-configs'
-import validate, { Joi } from './'
+import { Joi } from './'
+
+const validate = require('./index').validateRoot
 
 describe('.', () => {
   let sandbox

test/passing-configs/webpack-multi-compiler.js

@@ -0,0 +1,35 @@
+/**
+ *
+ * @link https://github.com/webpack/webpack/blob/master/examples/multi-compiler/webpack.config.js
+ *
+ */
+
+var path = require("path");
+var webpack = require('webpack')
+
+module.exports = [
+  {
+    entry: "./example",
+    output: {
+      path: path.join(__dirname, "js"),
+      filename: "mobile.js"
+    },
+    plugins: [
+      new webpack.DefinePlugin({
+        ENV: JSON.stringify("mobile")
+      })
+    ]
+  },
+  {
+    entry: "./example",
+    output: {
+      path: path.join(__dirname, "js"),
+      filename: "desktop.js"
+    },
+    plugins: [
+      new webpack.DefinePlugin({
+        ENV: JSON.stringify("desktop")
+      })
+    ]
+  }
+];

test/utils/allInvalid.js

@@ -1,6 +1,6 @@
-import validate from '../../src/index'
 import chalk from 'chalk'
 import util from 'util'
+import { validate } from '../../src'
 
 /**
  * For all supplied configs (array of objects), check that they are invalid given a schema.

test/utils/allValid.js

@@ -1,6 +1,6 @@
-import validate from '../../src/index'
 import chalk from 'chalk'
 import util from 'util'
+import { validate } from '../../src'
 
 /**
  * For all supplied configs (array of objects), check that they are valid given a schema.