SSLSocket#sysread do not copy bytes from buffer - instead re-use the backing array

kares · kares · commit 8e894e2e49ea · 2015-12-21T17:26:14.000+01:00
diff --git a/src/main/java/org/jruby/ext/openssl/SSLSocket.java b/src/main/java/org/jruby/ext/openssl/SSLSocket.java
@@ -757,10 +757,9 @@ private IRubyObject sysreadImpl(final ThreadContext context,
                     if ( ex instanceof IRubyObject ) return (IRubyObject) ex; // :wait_readable
                 }
             }
-            byte[] bytesRead = new byte[read];
-            dst.position(dst.position() - read);
-            dst.get(bytesRead);
-            buffStr.setValue(new ByteList(bytesRead, false));
+            final byte[] bytesRead = dst.array();
+            final int offset = dst.position() - read;
+            buffStr.setValue(new ByteList(bytesRead, offset, read, false));
             return buffStr;
         }
         catch (IOException ioe) {

Original file line number	Diff line number	Diff line change
`@@ -757,10 +757,9 @@ private IRubyObject sysreadImpl(final ThreadContext context,`
`757`	`757`	`if ( ex instanceof IRubyObject ) return (IRubyObject) ex; // :wait_readable`
`758`	`758`	`}`
`759`	`759`	`}`
`760`		`- byte[] bytesRead = new byte[read];`
`761`		`- dst.position(dst.position() - read);`
`762`		`- dst.get(bytesRead);`
`763`		`- buffStr.setValue(new ByteList(bytesRead, false));`
	`760`	`+ final byte[] bytesRead = dst.array();`
	`761`	`+ final int offset = dst.position() - read;`
	`762`	`+ buffStr.setValue(new ByteList(bytesRead, offset, read, false));`
`764`	`763`	`return buffStr;`
`765`	`764`	`}`
`766`	`765`	`catch (IOException ioe) {`