Skip to content

Commit e65a725

Browse files
committed
Fix several schema dump test for postgres
https://github.com/rails/rails/blob/7-1-stable/activerecord/lib/active_record/connection_adapters/mysql2/database_statements.rb#L21 https://github.com/rails/rails/blob/7-1-stable/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb#L63 there is diference between mysql/sqllite and postgres internal_exec_query method arity however due default values is not a issue at least for AR 7.1 some error example: Error: test_schema_dump(PostgresSchemaDumpTest): ArgumentError: unknown keywords: :allow_retry, :materialize_transactions /home/jessec/bryk/vendor_gems/stable/activerecord-jdbc-adapter/lib/arjdbc/abstract/database_statements.rb:37:in `internal_exec_query' /home/jessec/.gem/jruby/3.1.4/gems/activerecord-7.1.3.4/lib/active_record/connection_adapters/postgresql/schema_statements.rb:549:in `foreign_keys'
1 parent 3e1bf96 commit e65a725

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/arjdbc/abstract/database_statements.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def exec_insert(sql, name = nil, binds = NO_BINDS, pk = nil, sequence_name = nil
3333

3434
# It appears that at this point (AR 5.0) "prepare" should only ever be true
3535
# if prepared statements are enabled
36-
def internal_exec_query(sql, name = nil, binds = NO_BINDS, prepare: false, async: false)
36+
def internal_exec_query(sql, name = nil, binds = NO_BINDS, prepare: false, async: false, allow_retry: false, materialize_transactions: true)
3737
sql = transform_query(sql)
3838

3939
if preventing_writes? && write_query?(sql)

0 commit comments

Comments
 (0)