Fix postgres schema dump tests limit and array default and minor refactor

Author: JesseChavez

lib/arjdbc/postgresql/adapter.rb

@@ -97,8 +97,7 @@ def configure_connection
         end
       end
 
-      @type_map = Type::HashLookupTypeMap.new
-      initialize_type_map
+      reload_type_map
     end
 
     # @private
@@ -125,7 +124,7 @@ def configure_connection
       inet:         { name: 'inet' },
       int4range:    { name: 'int4range' },
       int8range:    { name: 'int8range' },
-      integer:      { name: 'integer' },
+      integer:      { name: 'integer', limit: 4 },
       interval:     { name: 'interval' },
       json:         { name: 'json' },
       jsonb:        { name: 'jsonb' },

lib/arjdbc/postgresql/oid_types.rb

@@ -118,8 +118,15 @@ def get_oid_type(oid, fmod, column_name, sql_type = '') # :nodoc:
       end
 
       def reload_type_map
-          type_map.clear
+        @lock.synchronize do
+          if @type_map
+            type_map.clear
+          else
+            @type_map = Type::HashLookupTypeMap.new
+          end
+
           initialize_type_map
+        end
       end
 
         def initialize_type_map_inner(m)
@@ -274,10 +281,6 @@ def extract_precision(sql_type)
         $1.to_i if sql_type =~ /\((\d+)(,\d+)?\)/
       end
 
-      def extract_limit(sql_type)
-        $1.to_i if sql_type =~ /\((.*)\)/
-      end
-
       # Support arrays/ranges for defining attributes that don't exist in the db
       ActiveRecord::Type.add_modifier({ array: true }, OID::Array, adapter: :postgresql)
       ActiveRecord::Type.add_modifier({ range: true }, OID::Range, adapter: :postgresql)

test/db/postgresql/schema_dump_test.rb

@@ -58,6 +58,7 @@ def test_schema_dump_should_not_have_limits_on_text_or_date
   def test_schema_dump_integer_with_no_limit_should_have_no_limit
     dump = dump_with_data_types
     lines = dump.lines.grep(/sample_integer_no_limit/)
+
     assert ! lines.empty?
     lines.each { |line| assert line !~ /:limit|limit:/ }
   end