Skip to content

Commit 4353682

Browse files
committed
Merge branch '50-stable' into 51-stable
* 50-stable: [test] db_version helper working on 5.X as well
2 parents 9f47eaf + 9bffcda commit 4353682

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

test/db/mysql/change_column_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class MySQLChangeColumnTest < Test::Unit::TestCase
1313
ActiveRecord::Migration.add_column :people, :about, :string, :default => 'x'
1414
# NOTE: even in non strict mode MySQL does not allow us add or change
1515
# text/binary with a default ...
16-
if mariadb_server? && ActiveRecord::Base.connection.database_version >= '10.2'
16+
if mariadb_server? && db_version >= '10.2'
1717
ActiveRecord::Migration.change_column :people, :about, :text
1818
else
1919
assert_raises ActiveRecord::StatementInvalid do

test/db/mysql/test_helper.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@ def mariadb_driver?; end unless defined? JRUBY_VERSION
2222
def mariadb_server?; connection.send(:mariadb?) end
2323
alias mariadb? mariadb_server?
2424

25+
def database_version
26+
ActiveRecord::Base.connection.raw_connection.full_version
27+
end
28+
alias db_version database_version
29+
2530
end
2631

2732
class Test::Unit::TestCase

0 commit comments

Comments
 (0)