Skip to content

Add Checking Information to Statistics Report #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlink opened this issue Jan 30, 2020 · 3 comments
Open

Add Checking Information to Statistics Report #87

jlink opened this issue Jan 30, 2020 · 3 comments

Comments

@jlink
Copy link
Collaborator

jlink commented Jan 30, 2020

Testing Problem

Discussing #75 resulted in the following idea by @luvarqpp

[SignUpTests:arbitraryQaronUserIsAlwaysValid] (2000) passwdLength = 
    more than 13 (1360) : 68 %       #checked by "percentage > 3.14"
    9..13        ( 228) : 11 %
    4..8         ( 222) : 11 %
    1..3         ( 124) :  6 %
    zero         (  66) :  3 %                #checked by "count > 10"

Solution Idea

Having the exact checking code is probably not possible (or only with large effort) but a simple

    more than 13 (1360) : 68 %       # checked percentage coverage
    zero         (  66) :  3 %                # checked count coverage

would be.

@luvarqpp
Copy link
Contributor

Seems fair.
Sidenote: I expect that CoverageChecker.count/percentage with Consumer as parameter will not mark line in report as "#checked...".

PS: Feel free to suggest other type of mark. My mind is seeing ascii color as background in case that tests are run from supported console, but I think that there are no support for detecting such case in junit. Have a look at maven as an example.

@jlink
Copy link
Collaborator Author

jlink commented Jan 30, 2020

Sidenote: I expect that CoverageChecker.count/percentage with Consumer as parameter will not mark line in report as "#checked...".

Why not? Using assertions (Consumer) or a predicate looks equivalent to me.

@luvarqpp
Copy link
Contributor

Sidenote: I expect that CoverageChecker.count/percentage with Consumer as parameter will not mark line in report as "#checked...".

Why not? Using assertions (Consumer) or a predicate looks equivalent to me.

My (initial) view is that when I am using Consumer, I am not able to "not fulfill check". It can be used for example for some legal issues, as consuming actual count of tries and saving it to database (or sending it by email) as an evidence that test has been done given number of times. This does not involve any sort of check. Just saving some information.

Predicate on the other hand, does directly influence result of "being checked". It does actually return boolean value of check result.

i.e. I feel that mark "#checked..." should be shown only on statistics lines, which have been checked by some Predicate.

PS: My view is now forked, because after some reasoning... If info about marking given statistics as "#checked..." is placed in javadoc also for Consumer version of method, It is imho OK to mark also those lines (i.e. your point of view). Name of method in both types of parameters is named check, so what I am complaining about :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants