wallet/tests: Enable SIlent Payments in ListCoinsTest

Author: Eunovo

src/wallet/test/util.cpp

@@ -27,6 +27,7 @@ std::unique_ptr<CWallet> CreateSyncedWallet(interfaces::Chain& chain, CChain& cc
     {
         LOCK(wallet->cs_wallet);
         wallet->SetWalletFlag(WALLET_FLAG_DESCRIPTORS);
+        wallet->SetWalletFlag(WALLET_FLAG_SILENT_PAYMENTS);
         wallet->SetupDescriptorScriptPubKeyMans();
 
         FlatSigningProvider provider;

src/wallet/test/wallet_tests.cpp

@@ -376,11 +376,23 @@ class ListCoinsTestingSetup : public TestChain100Setup
     {
         CTransactionRef tx;
         CCoinControl dummy;
+        if (std::holds_alternative<V0SilentPaymentDestination>(recipient.dest)) {
+            dummy.m_silent_payment = true;
+        }
         {
             auto res = CreateTransaction(*wallet, {recipient}, /*change_pos=*/std::nullopt, dummy);
             BOOST_CHECK(res);
             tx = res->tx;
         }
+        std::map<COutPoint, Coin> spent_coins;
+        for (const CTxIn& txin : tx->vin) {
+            spent_coins[txin.prevout]; // Create empty map entry keyed by prevout.
+        }
+        wallet->chain().findCoins(spent_coins);
+        {
+            LOCK(wallet->cs_wallet);
+            wallet->IsMine(*tx, spent_coins);
+        }
         wallet->CommitTransaction(tx, {}, {});
         CMutableTransaction blocktx;
         {
@@ -492,10 +504,29 @@ BOOST_FIXTURE_TEST_CASE(BasicOutputTypesTest, ListCoinsTest)
     //   2. One UTXO from the change, due to payment address matching logic
 
     for (const auto& out_type : OUTPUT_TYPES) {
-        if (out_type == OutputType::UNKNOWN || out_type == OutputType::SILENT_PAYMENTS) continue;
+        if (out_type == OutputType::UNKNOWN) continue;
+        if (out_type == OutputType::SILENT_PAYMENTS) continue;
         expected_coins_sizes[out_type] = 2U;
         TestCoinsResult(*this, out_type, 1 * COIN, expected_coins_sizes);
     }
+
+    // Add a taproot UTXO to be used for creating a silent payment
+    util::Result<CTxDestination> dest = Assert(wallet->GetNewDestination(OutputType::BECH32M, ""));
+    AddTx(CRecipient{*dest, 1 * COIN, /*fSubtractFeeFromAmount=*/true});
+    CoinFilterParams filter;
+    filter.skip_locked = true;
+    available_coins = WITH_LOCK(wallet->cs_wallet, return AvailableCoins(*wallet, nullptr, std::nullopt, filter));
+    BOOST_CHECK_EQUAL(available_coins.coins[OutputType::BECH32M].size(), 2U);
+    // Expect 4 OutputType::BECH32M UTXOs
+    // 1. One UTXO as the recipient because Silent Payments produce taproot scriptPubKeys
+    // 2. One UTXO from the change, due to payment address matching logic
+    // 3. Two locked UTXOs from previous OutputType::BECH32M test
+    expected_coins_sizes[OutputType::BECH32M] = 4U;
+    // Expect 2 OutputType::BECH32M UTXOs
+    // 1. One UTXO from mining the previous block
+    // 1. One UTXO from mining the block used in the test
+    expected_coins_sizes[OutputType::UNKNOWN] = 2U;
+    TestCoinsResult(*this, OutputType::SILENT_PAYMENTS, 1 * COIN, expected_coins_sizes);
 }
 
 BOOST_FIXTURE_TEST_CASE(wallet_disableprivkeys, TestChain100Setup)